Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake_policy in vcpkg #41574

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update cmake_policy in vcpkg #41574

wants to merge 10 commits into from

Conversation

gwankyun
Copy link

Compatibility with versions of CMake older than 3.10 is deprecated.

Compatibility with versions of CMake older than 3.10 is deprecated.
scripts/buildsystems/vcpkg.cmake Outdated Show resolved Hide resolved
scripts/buildsystems/vcpkg.cmake Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

/azp run

@BillyONeal
Copy link
Member

Rerunning due to network mistake last night.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimwang118 jimwang118 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Oct 16, 2024
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Oct 17, 2024
@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Oct 18, 2024
@BillyONeal
Copy link
Member

I think this should be set to 3.16.3
Related: microsoft/vcpkg-docs#415

Tagging vcpkg-team-review to confirm with other maintainers.

@dg0yt
Copy link
Contributor

dg0yt commented Oct 18, 2024

I think this should be set to 3.16.3

Do you want to raise the general minimum CMake version (as avaiable in Ubuntu 20.04)?
(Just asking.)

@BillyONeal
Copy link
Member

Do you want to raise the general minimum CMake version (as avaiable in Ubuntu 20.04)?
(Just asking.)

That's what I'm arguing, yes. The reason we cared about old CMake versions is "work with the CMake the downstream customer is likely to be using on our supported Linuxes", so with Debian 10 "Buster" leaving support the new oldest distro we care about is Ubuntu 20.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants