-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[faiss] update to 1.8.0 #41161
base: master
Are you sure you want to change the base?
[faiss] update to 1.8.0 #41161
Conversation
When testing feature
|
my local file like that: Does your is |
I has not test all features. |
I have to wait a few days before I can test gpu feature. My computer with gpu is broken and need repaired. |
I can reproduce the build error, but I don't know the cause. |
feature gpu(x64-windows), Use faiss 1.7.4 also can't build successfully |
@MonicaLiu0311 could you please see that on your machine if faiss port's gpu feature can successfully build on x64-windows before this pr's update? faiss-1.7.4 , in my local machine also fail. |
This is the result of running
E:\vcpkg\buildtrees\faiss\install-x64-windows-dbg-out.log:
|
@MonicaLiu0311 gpu feature. |
Yes, it failed to install before your PR. |
as #41738 @WangWeiLin-MV said that: It's an upstream issue facebookresearch/faiss#2985, so the port feature [gpu] should be disabled on Windows. so disable gpu feature on windows. |
The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.