Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gmp] Feature fat couldn't build on Windows #30177

Merged
merged 6 commits into from
Mar 20, 2023

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Mar 14, 2023

Fixes #27957, gmp[fat] can't build on windows because the following error, so change it supports to disable windows build temporarily.

Thanks fkonvick's investigation and dg0yt's help ♥.

C:\BUILD\vcpkg\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4686): error C2071: 'preinv_mod_1': illegal storage classlibtool: compile:  .././../src/v6.2.1-0c723d4b6f.clean/mpn/m4-ccas --m4=m4 clang.exe -DHAVE_CONFIG_H -I. -I.././../src/v6.2.1-0c723d4b6f.clean/mpn -I.. -D__GMP_WITHIN_GMP -I.././../src/v6.2.1-0c723d4b6f.clean -DOPERATION_x86_64_mod_34lsub1 -DWIN32 -D_WINDOWS -D_DEBUG -c --target=x86_64-pc-windows-msvc x86_64_mod_34lsub1.asm  -DDLL_EXPORT -DPIC -o .libs/x86_64_mod_34lsub1.obj

C:\BUILD\vcpkg\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4687): error C2071: 'redc_1': illegal storage class
C:\BUILD\vcpkg\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4688): error C2071: 'redc_2': illegal storage class
C:\BUILD\vcpkg\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4689): error C2071: 'rshift': illegal storage class
C:\BUILD\vcpkg\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4690): error C2071: 'sqr_basecase': illegal storage class
C:\BUILD\vcpkg\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4691): error C2071: 'sub_n': illegal storage class
C:\BUILD\vcpkg\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4692): error C2071: 'sublsh1_n': illegal storage class
C:\BUILD\vcpkg\buildtrees\gmp\src\v6.2.1-0c723d4b6f.clean\gmp-impl.h(4693): error C2071: 'submul_1': illegal storage class
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 14, 2023
@LilyWangLL LilyWangLL marked this pull request as ready for review March 14, 2023 09:37
Cheney-W
Cheney-W previously approved these changes Mar 15, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 15, 2023
ports/gmp/vcpkg.json Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Mar 15, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 20, 2023
@dan-shaw dan-shaw merged commit 7502c79 into microsoft:master Mar 20, 2023
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue27957 branch March 23, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gmp] Build error - 'fat' does not build on Windows x64
4 participants