Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CG issue in Microsoft.IO.Redist #757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DaveTryon
Copy link
Contributor

CVE-2024-38081 impacts .NET Framework and .NET version 6.X. .NET 8 is not impacted. This was a manually-generated change, scoped to just the .NET Framework build, because the tooling can't automatically keep the file for .NET Framework and exclude it for .NET 8.

If future versions of Microsoft.Build.Utilities.Core and Microsoft.Build eventually include the new version dependency, then we should be able to revert this change.

Redacted output of dotnet nuget why before this change--the key point is Microsoft.IO.Redist v6.0.0:

>dotnet nuget why Microsoft.Sbom.sln Microsoft.IO.Redist
Project 'Microsoft.Sbom.Targets' has the following dependency graph(s) for 'Microsoft.IO.Redist':
  [net472]
   │
   └─ Microsoft.Build.Utilities.Core (v17.11.4)
      └─ Microsoft.IO.Redist (v6.0.0)

Project 'Microsoft.Sbom.Targets.Tests' has the following dependency graph(s) for 'Microsoft.IO.Redist':
  [net472]
   │
   └─ Microsoft.Build.Utilities.Core (v17.11.4)
      └─ Microsoft.IO.Redist (v6.0.0)

Project 'Microsoft.Sbom.Targets.E2E.Tests' has the following dependency graph(s) for 'Microsoft.IO.Redist':
  [net472]
   │
   ├─ Microsoft.Build (v17.3.2)
   │  └─ Microsoft.IO.Redist (v6.0.0)
   └─ Microsoft.Build.Utilities.Core (v17.11.4)
      └─ Microsoft.IO.Redist (v6.0.0)

Redacted output of dotnet nuget why after this change--the key point is Microsoft.IO.Redist v6.0.1:

>dotnet nuget why Microsoft.Sbom.sln Microsoft.IO.Redist
Project 'Microsoft.Sbom.Targets' has the following dependency graph(s) for 'Microsoft.IO.Redist':
  [net472]
   │
   ├─ Microsoft.Build.Utilities.Core (v17.11.4)
   │  └─ Microsoft.IO.Redist (v6.0.1)
   └─ Microsoft.IO.Redist (v6.0.1)

Project 'Microsoft.Sbom.Targets.Tests' has the following dependency graph(s) for 'Microsoft.IO.Redist':
  [net472]
   │
   ├─ Microsoft.Build.Utilities.Core (v17.11.4)
   │  └─ Microsoft.IO.Redist (v6.0.1)
   └─ Microsoft.IO.Redist (v6.0.1)

Project 'Microsoft.Sbom.Targets.E2E.Tests' has the following dependency graph(s) for 'Microsoft.IO.Redist':
  [net472]
   │
   ├─ Microsoft.Build (v17.3.2)
   │  └─ Microsoft.IO.Redist (v6.0.1)
   ├─ Microsoft.Build.Utilities.Core (v17.11.4)
   │  └─ Microsoft.IO.Redist (v6.0.1)
   └─ Microsoft.IO.Redist (v6.0.1)

@DaveTryon DaveTryon requested a review from a team as a code owner October 21, 2024 17:59
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.85%. Comparing base (552c36c) to head (0e1061a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   70.13%   66.85%   -3.28%     
==========================================
  Files         277      277              
  Lines        8651     8651              
  Branches     1006     1006              
==========================================
- Hits         6067     5784     -283     
- Misses       2065     2356     +291     
+ Partials      519      511       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants