-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Add docs about architecture and fix structure #1229
Conversation
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Able to run Build
Serve
|
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
Signed-off-by: Kamil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a section at the very start to explain very high level concepts and capture them in a high-level diagram. This should include data-plane, control-plane, and the types of data-plane. Also, what are the Kubernetes resources that contain the data plane and control-plane (i.e. agent daemonset, operator). Maybe add this in a separate PR as a second iteration? Approving anyway, great work @kamilprz thanks!
…scripts and docs (microsoft#1259) # Description This pull request includes significant changes to transition from the "legacy" to the "standard" directory and package structure. The changes involve updates to Helm charts, Makefile commands, package imports, and file paths. Directory and package structure updates: * [`.github/workflows/release-charts.yaml`](diffhunk://#diff-711012dcc1f315d20ef98e04b14cbc0cb1a388641934c2151ac99f74ff11f62cL43-R43): Updated the Helm package path from `legacy` to `standard`. * [`Makefile`](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L447-R447): Updated multiple Helm install commands to use the `standard` directory instead of `legacy`. [[1]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L447-R447) [[2]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L460-R460) [[3]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L477-R477) [[4]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L496-R496) * [`cmd/root.go`](diffhunk://#diff-ab967ab1a2f3a1b769106eeb7bfe892ef0e81d1d27811fa15be08e6749feee1fL9-R9): Changed package imports and daemon initialization from `legacy` to `standard`. [[1]](diffhunk://#diff-ab967ab1a2f3a1b769106eeb7bfe892ef0e81d1d27811fa15be08e6749feee1fL9-R9) [[2]](diffhunk://#diff-ab967ab1a2f3a1b769106eeb7bfe892ef0e81d1d27811fa15be08e6749feee1fL31-R31) * Renamed files from `legacy` to `standard`: * `cmd/legacy/daemon.go` to `cmd/standard/daemon.go` * `cmd/legacy/daemon_linux.go` to `cmd/standard/daemon_linux.go` * `cmd/legacy/daemon_windows.go` to `cmd/standard/daemon_windows.go` * [`crd/Makefile`](diffhunk://#diff-414956f6f35c3bc4a93c4c08592ee22397d76d99a1b728e1e33c65075a2a99c8L7-R7): Updated the `HELM_CRD_DIR` path to use the `standard` directory. File deletions and renames: * Deleted `deploy/legacy/prometheus/retina/create-cm.sh`. * Renamed `deploy/legacy/manifests/controller/helm/retina/templates/NOTES.txt` to `deploy/standard/manifests/controller/helm/retina/templates/NOTES.txt` with updated paths inside the file. ## Related Issue This PR will close microsoft#1115 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Ritwik Ranjan <[email protected]> Co-authored-by: kamilprz <[email protected]>
# Description Add `metricscardinality` to heartbeat. This will give visibility on the number of time series being exposed by retina. ## Related Issue microsoft#1040 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Metrics exported with heartbeat: ![image](https://github.com/user-attachments/assets/6fb4d76b-5780-4751-91c0-46e3c4f0fb85) ## Additional Notes Metrics of types `histogram` and `summary` expose multiple time series during a scrape. Code is counting according to number of time series exposed at /metrics endpoint. Ref: https://prometheus.io/docs/concepts/metric_types/#histogram https://prometheus.io/docs/concepts/metric_types/#summary --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. Signed-off-by: Alex Castilio dos Santos <[email protected]>
Description
The main goal of this PR was to document the Retina architecture, namely the data plane and the available control planes. While working on this, I also made some smaller changes to improve our consistency.
What this PR does:
Smaller changes
Architecture docs
.png
and the source for the diagram.excalidraw
are included so that the diagrams can be versioned.retina.sh
in terms of the feature descriptions. Also added a "What is Hubble?" subsection with a brief description.Related Issue
#1055
There is also another PR opened for Hubble installation - #1223
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
I think its a bit redundant to put the Architecture Diagrams in here, as the files themselves are included. So check those out directly. Or open up a preview of the markdown page itself in GitHub.
Retina favicon image
Example of new file structure - showcasing that the heading now opens rather than having a landing page when clicked on.
Parity of feature highlight between
retina.sh
and "What is Retina?" page.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.