Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Add doc for Hubble control plane and metrics #1194

Merged
merged 9 commits into from
Jan 10, 2025
Merged

chore(docs): Add doc for Hubble control plane and metrics #1194

merged 9 commits into from
Jan 10, 2025

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Jan 7, 2025 •
edited
Loading

Description

Initial PR to add documentation for Hubble control plane and metrics.

Related Issue

#1055
#1093

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image

image

image

image

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@SRodi SRodi requested a review from a team as a code owner January 7, 2025 17:50
@SRodi SRodi requested review from rbtr and alexcastilio January 7, 2025 17:50
kamilprz
kamilprz previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@kamilprz kamilprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs :)

@SRodi SRodi requested review from nddq and kamilprz January 8, 2025 15:25
@SRodi SRodi requested a review from nddq January 10, 2025 15:22
@SRodi SRodi added this pull request to the merge queue Jan 10, 2025
Merged via the queue into microsoft:main with commit e31cc3c Jan 10, 2025
27 checks passed
@SRodi SRodi deleted the chore/docs branch January 10, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilprz kamilprz kamilprz approved these changes

@nddq nddq nddq approved these changes

@vakalapa vakalapa vakalapa approved these changes

@rbtr rbtr Awaiting requested review from rbtr rbtr is a code owner automatically assigned from microsoft/retina

@alexcastilio alexcastilio Awaiting requested review from alexcastilio alexcastilio is a code owner automatically assigned from microsoft/retina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SRodi @vakalapa @nddq @kamilprz