Update test callable discovery to work within the language service #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
approved these changes
Jan 27, 2025
minestarks
reviewed
Jan 27, 2025
minestarks
reviewed
Jan 27, 2025
minestarks
reviewed
Jan 27, 2025
minestarks
reviewed
Jan 27, 2025
minestarks
reviewed
Jan 27, 2025
minestarks
reviewed
Jan 27, 2025
minestarks
approved these changes
Jan 27, 2025
Co-authored-by: Mine Starks <[email protected]>
Co-authored-by: Mine Starks <[email protected]>
billti
reviewed
Jan 28, 2025
billti
reviewed
Jan 28, 2025
billti
reviewed
Jan 28, 2025
idavis
pushed a commit
that referenced
this pull request
Feb 2, 2025
…2095) This PR rewrites #2059 to trigger test discovery from within the language server, as opposed to externally in an entirely separate context. Please read the description in that PR for more detail. It also adds tests for LS state in both the Rust-based LS tests and the JS-based `basics.js` npm API tests. --------- Co-authored-by: Mine Starks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites #2059 to trigger test discovery from within the language server, as opposed to externally in an entirely separate context. Please read the description in that PR for more detail.
It also adds tests for LS state in both the Rust-based LS tests and the JS-based
basics.jsnpm API tests.