Add stubs for RMSE and RMSLE in sklearn.metrics #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarwar
changed the title
|
@microsoft-github-policy-service agree |
That sounds good to me! I took the liberty of making this change in your branch. |
debonte
approved these changes
Sep 19, 2024
|
Thanks for your contribution @einarwar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates sklearn.metrics stubs with changes introduced in v1.4 in scikit-learn/scikit-learn#26734
Originally wanted to mark old function parameters are deprecated, but i guess that isn't possible until PEP702
Related issue from pylance: microsoft/pylance-release#6410