Add keyboard navigation and custom styles for focused elements #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix focus order. Elements should be focused top to bottom |
MulyukovAidar
added a commit
that referenced
this pull request
Jan 12, 2024
* Update build.yml (#69) * New translations * Add keyboard navigation and custom styles for focused elements (#70) * Add keyboard navigation and custom styles for focused elements * Add keyboard navigation tests * Refactor test and remove unnecessary import * Reverse the order of the series so that the focus goes from up to down. * Remove unused dependencies, update Node version to 20.x * Update .build.yml * Resolve conflict errors * Remove outline on non-keyboard focus. Fix stream focus order. (#72) * Remove outline on non-keyboard focus. Fix focus order * Remove tslint.json and specify Chromium path for karma tests * Fix focus order: goes from down to up * Fix version to use 4 digits * Update version to 3.0.5.0 (#73) * New translations (#64) merging localizations * Revert "New translations (2023-09-07 13:06:52 UTC)" (#76) --------- Co-authored-by: pbicvloc <[email protected]> Co-authored-by: adiletelf <[email protected]>
MulyukovAidar
added a commit
that referenced
this pull request
Jun 3, 2024
* New translations * Add keyboard navigation and custom styles for focused elements (#70) * Add keyboard navigation and custom styles for focused elements * Add keyboard navigation tests * Refactor test and remove unnecessary import * Reverse the order of the series so that the focus goes from up to down. * Remove unused dependencies, update Node version to 20.x * Update .build.yml * Resolve conflict errors * Remove outline on non-keyboard focus. Fix stream focus order. (#72) * Remove outline on non-keyboard focus. Fix focus order * Remove tslint.json and specify Chromium path for karma tests * Fix focus order: goes from down to up * Fix version to use 4 digits * Update version to 3.0.5.0 (#73) * New translations (#64) merging localizations * Revert "New translations (2023-09-07 13:06:52 UTC)" (#76) * Add support for ContextMenu when clicking on empty space (#78) * Add support for ContextMenu when clicking on empty space When right-clicking on empty space the context menu is shown with actions like copy, share and so on. * Fix don't show contextmenu twice when clicking on stream * Replace playwright with playwright-chromium * Update powerbi-visuals-api to 5.7.0 (#79) * New translations * Fix render bugs and enhance readability in high contrast mode (#82) * Fix "Data Labels" Card, remove redundant slicer "show" * Make label color visible in high contrast mode when it's the same as background color * Force high contrast colors in high contrast mode * Fix colors in high contrast mode for axis and legend (#83) * Fix colors in high contrast mode for axis and legend * Increase version to 3.0.8.0 * Fix entry for 3.0.8.0 in CHANGELOG.md * Bump version to 3.0.9.0 (#84) * Bump version to 3.0.9.0 * Update packages * Revert "Update packages" This reverts commit baed5fc. --------- Co-authored-by: pbicvloc <[email protected]> Co-authored-by: adiletelf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I tested multiple selection with keyboard using
Ctrl,Shift,Metakeys and it works.