-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlap KV cache update for WindowedKeyValueCache in DecoderOnlyPipelineState #1222
Draft
edgchen1
wants to merge
11
commits into
main
Choose a base branch
from
edgchen1/overlap_kv_cache_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
commented
Feb 4, 2025
@@ -100,39 +101,7 @@ struct CrossCache { | |||
std::vector<std::string> input_name_strings_, output_name_strings_; | |||
}; | |||
|
|||
struct WindowedKeyValueCache : KeyValueCache { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: moved WindowedKeyValueCache
to windowed_kv_cache.h/cpp
edgchen1
commented
Feb 4, 2025
@@ -23,7 +18,7 @@ target_include_directories(unit_tests PRIVATE | |||
target_link_directories(unit_tests PRIVATE ${ORT_LIB_DIR}) | |||
target_link_libraries(unit_tests PRIVATE | |||
onnxruntime-genai-static | |||
GTest::gtest_main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: there's already a main
in test/main.cpp
so we don't need one from gtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for overlapping the KV cache update for a pipelined model part with the graph execution of other pipelined model parts. It only applies to
DecoderOnlyPipelineState
withWindowedKeyValueCache
.For example, consider a model with two parts (graph[1] and graph[2]) that have KV caches.
This is the approach in this PR:
For comparison, this is the existing approach:
TODO measurements