Spelling #704

jsoref · 2021-09-24T13:54:09Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@9ac24b5#commitcomment-57009226

The action reports that the changes in this PR would make it happy: jsoref@4bed8ca

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Disclaimer: GitHub does not like PRs w/ >250 commits (this has 465 at the time of filing). In general, reviewing windowed views is probably better than most alternatives (the standard git cli's diff output is fairly unhelpful for PRs like this).

Note: I fully expect to be asked to split this PR / reorganize it. If there are files that shouldn't be changed, let me know, dropping files is easy. If there are terms that can't be changed, that's also easy -- right now, a term is localized to a single commit, so dropping it means just dropping the commit.

It's possible for me to split by kind of content (comment vs code), but such things are moderately expensive and I try to do it as few times as possible and as late as possible.

I'll try to include annotations about the changes, but it'll take me a bit (it's a long PR)

Signed-off-by: Josh Soref <[email protected]>

jsoref · 2021-09-24T13:54:52Z

Unix/base/class.c

@@ -909,7 +909,7 @@ MI_Char *restrictedQualifier[] = {
                                    ZT("Version"),
                                    ZT("ClassVersion")
                                 };
-MI_Boolean CanQualifierBePropogated( _In_ MI_Qualifier *qualifier)
+MI_Boolean CanQualifierBePropagated( _In_ MI_Qualifier *qualifier)


This is a change to an identifier, it looks local, and is thus unlikely to be particularly exciting.

jsoref · 2021-09-24T13:55:52Z

Unix/base/oi_traces.h

@@ -132,9 +132,9 @@ OI_EVENT("MuxIn_Open: cannot allocate ConnectionIn")
 void trace_MuxInOpen_AllocFailed();

 OI_EVENT("_StrandEntryOperation_Add: Canceled %d entries %p(%s): %p(%s)")
-void trace_StrandEntryOperation_AddCanceled(unsigned int numEntries, StrandMany * self, const char * selfTrand, Strand * entry, const char * entryStrandName);
+void trace_StrandEntryOperation_AddCanceled(unsigned int numEntries, StrandMany * self, const char * selfStrand, Strand * entry, const char * entryStrandName);


I'm guessing based on the rest of the content of the line. (Google Sheets made most of the corrections, but it didn't have an opinion here, so this was manual intervention.)

jsoref · 2021-09-24T13:56:20Z

Unix/base/oi_traces.h

@@ -615,13 +615,13 @@ void trace_InstanceConversionFailed(const TChar * name, MI_Result r);
 OI_EVENT("invalid query expression: %T")
 void trace_InvalidQueryExpression(const TChar * filter);
 OI_EVENT("library unload did not call post result")
-void trace_LibraryUnload_DidnotPostResult();
+void trace_LibraryUnload_DidNotPostResult();


This is a change to an API of sorts. Happy to drop if it's a problem.

jsoref · 2021-09-24T13:57:02Z

Unix/base/oi_traces.h

@@ -1105,7 +1105,7 @@ void trace_DispHandleInteractionRequest(void * self, Interaction * interaction,
 OI_EVENT("Disp_HandleInteractionRequest: self (%p), interaction(%p), Unsupported msg(%p:%d:%T:%x)")
 void trace_DispUnsupportedMessage(void * self, Interaction * interaction, Message * msg, MI_Uint32 msgTag, const TChar * messageName, MI_Uint64 operationId);
 OI_EVENT("Disp_HandleRequest")
-void trace_DispHandlRequest();
+void trace_DispHandleRequest();


While the previous one is stylistic, this one matches the name of the event on the preceding line. And it feels like a more problematic typo.

jsoref · 2021-09-24T13:57:11Z

Unix/base/oi_traces.h

@@ -1415,7 +1415,7 @@ void trace_InitIndicationWithNullInput();
 OI_EVENT("Multiple indication initialization of provider for class %T")
 void trace_MultipleIndication_InitOfProviderForClass(const TChar * className);

-OI_EVENT("_Provider_InvokeSubscribe: Start  Thread %x: provider (%p), msg (%p) with tag (%d), subcription (%p)")
+OI_EVENT("_Provider_InvokeSubscribe: Start  Thread %x: provider (%p), msg (%p) with tag (%d), subscription (%p)")


debug output change?

jsoref · 2021-09-24T14:44:20Z

Unix/ut/win/acv/winomi_test.cmd

@@ -9,7 +9,7 @@ SET TESTDIR=%BINPATH%\tests
 SET LOGDIR=%CD%
 SET LOGFILENAME=%LOGDIR%\test.log

-ECHO Current Direcotry: %LOGDIR% >%LOGFILENAME%  2>&1
+ECHO Current Directory: %LOGDIR% >%LOGFILENAME%  2>&1


user facing...

jsoref · 2021-09-24T14:44:53Z

Unix/wsman/wsman.c

    MI_Uint32   totalResponses;

-    /* lower 16 bits is aninxed in self->enumerateContexts, upper 16 bits are random data (for validation) */


jsoref · 2021-09-24T14:46:02Z

Unix/wsman/wsman.c

@@ -4925,7 +4925,7 @@ static int _ValidateSubscribeRequest(
            selfCD,
            NULL,
            WSBUF_FAULT_INTERNAL_ERROR,
-            ZT("mandatory parameters (className, namesapce) are not provided for subscribe request"));
+            ZT("mandatory parameters (className, namespace) are not provided for subscribe request"));


user facing?

jsoref · 2021-09-24T14:47:37Z

Unix/xmlserializer/xmldeserializer_ids.h

@@ -8,17 +8,17 @@
 #define ID_MI_DES_XML_INST_TOO_MANY_CLASSES 4002
 #define ID_MI_DES_XML_INST_CANNOT_FIND_CLASS 4003
 #define ID_MI_DES_XML_CLASS_DERIVATION_LIST_WRONG 4004
-#define ID_MI_DES_XML_CLASS_SUPERCLASS_PARENT_MISSMATCH 4005
+#define ID_MI_DES_XML_CLASS_SUPERCLASS_PARENT_MISMATCH 4005


jsoref · 2021-09-24T14:48:26Z

Unix/xmlserializer/xmldeserializer_ids.h

@@ -27,17 +27,17 @@
 #define ID_MI_DES_XML_INST_TOO_MANY_CLASSES             PAL_T("Failed to deserialize CIM-XML document. The instance is too complex to deserialize because it uses too many classes.")
 #define ID_MI_DES_XML_INST_CANNOT_FIND_CLASS            PAL_T("Failed to deserialize CIM-XML document. Could not find the class definition %T while deserializing instance.")
 #define ID_MI_DES_XML_CLASS_DERIVATION_LIST_WRONG       PAL_T("Failed to deserialize CIM-XML document. A class definition has a SUPERCLASS attribute and a DERIVATION attribute. The SUPERCLASS attribute value should be the first item in the DERIVATION attribute list." )
-#define ID_MI_DES_XML_CLASS_SUPERCLASS_PARENT_MISSMATCH PAL_T("Failed to deserialize CIM-XML document. While decoding a class definition there was a mismatch between the SUPERCLASS attribute and the passed in parent class definition." )
+#define ID_MI_DES_XML_CLASS_SUPERCLASS_PARENT_MISMATCH PAL_T("Failed to deserialize CIM-XML document. While decoding a class definition there was a mismatch between the SUPERCLASS attribute and the passed in parent class definition." )


i try to avoid harming whitespace indentation, but I lost this -- I saw it in one pass, but the page reloaded and I couldn't find it

jsoref added 30 commits September 24, 2021 09:09

spelling: identifies

ffc09df

Signed-off-by: Josh Soref <[email protected]>

spelling: identifying

e99cf95

Signed-off-by: Josh Soref <[email protected]>

spelling: identity

9e48c8e

Signed-off-by: Josh Soref <[email protected]>

spelling: ignore

8ef4a1d

Signed-off-by: Josh Soref <[email protected]>

spelling: ignoring

cd5090d

Signed-off-by: Josh Soref <[email protected]>

spelling: immediately

56329a9

Signed-off-by: Josh Soref <[email protected]>

spelling: implementation

5cc36bd

Signed-off-by: Josh Soref <[email protected]>

spelling: implemented

ef2e55c

Signed-off-by: Josh Soref <[email protected]>

spelling: implicit

59c8d47

Signed-off-by: Josh Soref <[email protected]>

spelling: implies

b19fadd

Signed-off-by: Josh Soref <[email protected]>

spelling: improvement

e4562b1

Signed-off-by: Josh Soref <[email protected]>

spelling: include

44990be

Signed-off-by: Josh Soref <[email protected]>

spelling: incoming

ff09b87

Signed-off-by: Josh Soref <[email protected]>

spelling: indefinitely

b24ec5a

Signed-off-by: Josh Soref <[email protected]>

spelling: independently

d6ec129

Signed-off-by: Josh Soref <[email protected]>

spelling: indication

6176de7

Signed-off-by: Josh Soref <[email protected]>

spelling: indicative

52ddfb4

Signed-off-by: Josh Soref <[email protected]>

spelling: individual

fb7c89b

Signed-off-by: Josh Soref <[email protected]>

spelling: information

b86b16e

Signed-off-by: Josh Soref <[email protected]>

spelling: infrastructure

311c23f

Signed-off-by: Josh Soref <[email protected]>

spelling: inheritance

f451257

Signed-off-by: Josh Soref <[email protected]>

spelling: inherited

561f047

Signed-off-by: Josh Soref <[email protected]>

spelling: initial

b13a7e1

Signed-off-by: Josh Soref <[email protected]>

spelling: initialize

736f9fe

Signed-off-by: Josh Soref <[email protected]>

spelling: initialized

ee33d2b

Signed-off-by: Josh Soref <[email protected]>

spelling: initially

0419c4e

Signed-off-by: Josh Soref <[email protected]>

spelling: initiate

3aa5bfb

Signed-off-by: Josh Soref <[email protected]>

spelling: initiator

5d98aff

Signed-off-by: Josh Soref <[email protected]>

spelling: insensitive

58a93d0

Signed-off-by: Josh Soref <[email protected]>

spelling: instance

8fe0ad1

Signed-off-by: Josh Soref <[email protected]>

jsoref added 29 commits September 24, 2021 09:13

spelling: therefore

444767f

Signed-off-by: Josh Soref <[email protected]>

spelling: these capabilities

2df6cbc

Signed-off-by: Josh Soref <[email protected]>

spelling: thing

383e4c8

Signed-off-by: Josh Soref <[email protected]>

spelling: timeout

2fd7909

Signed-off-by: Josh Soref <[email protected]>

spelling: to the

b17457a

Signed-off-by: Josh Soref <[email protected]>

spelling: transaction

d5fd4cb

Signed-off-by: Josh Soref <[email protected]>

spelling: transferred

0b44104

Signed-off-by: Josh Soref <[email protected]>

spelling: transmitted

46d9a64

Signed-off-by: Josh Soref <[email protected]>

spelling: unary

76cc51d

Signed-off-by: Josh Soref <[email protected]>

spelling: unavailable

dad65c8

Signed-off-by: Josh Soref <[email protected]>

spelling: underneath

42db2c4

Signed-off-by: Josh Soref <[email protected]>

spelling: unexpected

0f2120a

Signed-off-by: Josh Soref <[email protected]>

spelling: unknown

f4341e1

Signed-off-by: Josh Soref <[email protected]>

spelling: unnecessarily

5c019c4

Signed-off-by: Josh Soref <[email protected]>

spelling: unsubscribe

f501581

Signed-off-by: Josh Soref <[email protected]>

spelling: unsupported

71dae8e

Signed-off-by: Josh Soref <[email protected]>

spelling: unzipped

8520392

Signed-off-by: Josh Soref <[email protected]>

spelling: update

db2cbd0

Signed-off-by: Josh Soref <[email protected]>

spelling: upon

03d52bc

Signed-off-by: Josh Soref <[email protected]>

spelling: utility

6a40dbe

Signed-off-by: Josh Soref <[email protected]>

spelling: validate

f076a84

Signed-off-by: Josh Soref <[email protected]>

spelling: value

5e8bea5

Signed-off-by: Josh Soref <[email protected]>

spelling: verified

c8d5545

Signed-off-by: Josh Soref <[email protected]>

spelling: version

31dfa5b

Signed-off-by: Josh Soref <[email protected]>

spelling: which

761fca1

Signed-off-by: Josh Soref <[email protected]>

spelling: with

9da812d

Signed-off-by: Josh Soref <[email protected]>

spelling: worrisome

f0e2532

Signed-off-by: Josh Soref <[email protected]>

spelling: wraparounds

b4804a8

Signed-off-by: Josh Soref <[email protected]>

spelling: yield

a007da9

Signed-off-by: Josh Soref <[email protected]>

jsoref commented Sep 24, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #704

Spelling #704

jsoref commented Sep 24, 2021 •

edited

Loading

jsoref Sep 24, 2021

jsoref Sep 24, 2021

jsoref Sep 24, 2021

jsoref Sep 24, 2021

jsoref Sep 24, 2021

jsoref Sep 24, 2021

jsoref Sep 24, 2021

jsoref Sep 24, 2021

jsoref Sep 24, 2021

jsoref Sep 24, 2021

		MI_Uint32 totalResponses;

		/* lower 16 bits is aninxed in self->enumerateContexts, upper 16 bits are random data (for validation) */

Spelling #704

Are you sure you want to change the base?

Spelling #704

Conversation

jsoref commented Sep 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsoref commented Sep 24, 2021 •

edited

Loading