[Expose TTL Follow up PR] move version logic to platform_xyz instead of datapath #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4740 +/- ##
==========================================
+ Coverage 85.74% 86.68% +0.93%
==========================================
Files 56 56
Lines 17378 17400 +22
==========================================
+ Hits 14901 15083 +182
+ Misses 2477 2317 -160 ☔ View full report in Codecov by Sentry. |
guhetier
reviewed
Jan 8, 2025
nibanks
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was some additional feedback from #4602
The biggest one being that we have the version fetching logic in a bunch of different places, let's instead standardize it in the CX_PLATFORM global object so subroutines can just reference it.
Testing
CI
Documentation
No.