Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview API feature #4730

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

masa-koz
Copy link
Contributor

@masa-koz masa-koz commented Jan 1, 2025

Description

This pull request introduces a new feature flag, preview-api, and updates the Settings struct and related methods in src/lib.rs. The most important changes include adding the new feature flag in Cargo.toml, updating the Settings struct to include a new field, adding a new method under the preview-api feature, and modifying a test function to conditionally use the new method based on the feature flag.

Testing

cargo test --features preview-api

Documentation

TBD

@masa-koz masa-koz requested a review from a team as a code owner January 1, 2025 08:09
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (b6ebb83) to head (656b0d9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4730      +/-   ##
==========================================
- Coverage   86.68%   85.83%   -0.86%     
==========================================
  Files          56       56              
  Lines       17363    17363              
==========================================
- Hits        15051    14903     -148     
- Misses       2312     2460     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit 38469af into microsoft:main Jan 2, 2025
483 of 484 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants