Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup release please #505

Merged
merged 4 commits into from
Jan 7, 2025
Merged

ci: setup release please #505

merged 4 commits into from
Jan 7, 2025

Conversation

andrueastman
Copy link
Member

Fixes #327

@andrueastman andrueastman force-pushed the andrueastman/setupReleasePlease branch from ab25118 to 8dfd7d8 Compare January 7, 2025 09:17
@andrueastman andrueastman changed the base branch from main to andrueastman/fixContentReading January 7, 2025 09:18
@andrueastman andrueastman changed the title [WIP] ci: setup release please ci: setup release please Jan 7, 2025
Base automatically changed from andrueastman/fixContentReading to main January 7, 2025 11:31
baywet
baywet previously approved these changes Jan 7, 2025
@baywet
Copy link
Member

baywet commented Jan 7, 2025

@andrueastman interesting, they now add checks when you change the configuration, and it seems some JSON is invalid (see the checks panel)

@andrueastman
Copy link
Member Author

and it seems some JSON is invalid (see the checks panel)

I'm not sure why it's failing here as the Json is valid.
I suspect the issue is that it's looking for the config files in main branch (which don't exist yet). We can probably try and merge and see if all is well?

@andrueastman andrueastman marked this pull request as ready for review January 7, 2025 13:12
@andrueastman andrueastman requested a review from a team as a code owner January 7, 2025 13:12
Signed-off-by: Vincent Biret <[email protected]>
Copy link

sonarqubecloud bot commented Jan 7, 2025

@baywet
Copy link
Member

baywet commented Jan 7, 2025

I tried removing the BOM from the encoding since it was complaining about index 0. I now do not see the checks anymore, I'm not sure whether this is because they are valid or because they don't trigger on push. Either way, we should be good to merge.

@baywet baywet merged commit 57d7a1a into main Jan 7, 2025
12 checks passed
@baywet baywet deleted the andrueastman/setupReleasePlease branch January 7, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress 🚧
Development

Successfully merging this pull request may close these issues.

Add release-please configuration
2 participants