Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for net9.0 #466

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat: support for net9.0 #466

merged 3 commits into from
Nov 13, 2024

Conversation

andrueastman
Copy link
Member

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andrueastman andrueastman marked this pull request as ready for review November 13, 2024 08:25
@andrueastman andrueastman requested a review from a team as a code owner November 13, 2024 08:25
calebkiage
calebkiage reviewed Nov 13, 2024
View reviewed changes
Copy link

@calebkiage calebkiage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the upper bound on the versions. This way, we won't have to update these files all the time.

I'm also wondering if we could just use latest versions of these libraries and let dependabot deal with the updates?

src/abstractions/Microsoft.Kiota.Abstractions.csproj Show resolved Hide resolved
src/authentication/azure/Microsoft.Kiota.Authentication.Azure.csproj Show resolved Hide resolved
src/http/httpClient/Microsoft.Kiota.Http.HttpClientLibrary.csproj Show resolved Hide resolved
tests/trimming/Microsoft.Kiota.Trimming.Validation/Microsoft.Kiota.Trimming.Validation.csproj Show resolved Hide resolved
src/http/httpClient/Microsoft.Kiota.Http.HttpClientLibrary.csproj Show resolved Hide resolved
src/serialization/json/Microsoft.Kiota.Serialization.Json.csproj Show resolved Hide resolved
@andrueastman andrueastman merged commit 49d3961 into main Nov 13, 2024
11 checks passed
@andrueastman andrueastman deleted the fix/net9 branch November 13, 2024 13:14
@tevinder
Copy link

System.Diagnostics.DiagnosticSource is still looking for version <9.0.0 in HttpClientLibrary

@baywet baywet mentioned this pull request Nov 13, 2024
Merged
@baywet
Copy link
Member

baywet commented Nov 13, 2024 •
edited
Loading

System.Diagnostics.DiagnosticSource is still looking for version <9.0.0 in HttpClientLibrary

Thanks for pointing this out. Put together #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@calebkiage calebkiage calebkiage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrueastman @tevinder @baywet @calebkiage