fix: allows dispatching keyborg:focusin
on focusable shadow root
#81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyborg doesn't dispatch
keyborg:focusin
for shadow roots when they get focus. Web components - e.g. fluent-button from Fluent UI Web Components - don't getkeyborg:focusin
dispatched for them because of that. The proposed fix letskeyborg:focusin
event be dispatched for focused shadow root.When focus goes back from element in shadow DOM to focusable shadow root (Shift+Tab), there's no
focusin
event dispatched for shadow root. The second part of the fix callsonFocusIn
fromfocusOutHandler
ifrelatedTarget
of blur event is shadow root and it contains target element in its shadow DOM.