Add support for CSHAKE #80
Conversation
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
cng/hash_test.go:35
- The return type should be consistent with the new return type of DigestSHA3.
return func() hash.Hash { return cng.NewSHA3_256() }
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
| // SumSHA3_256 returns the SHA3-256 checksum of the data. | ||
| func SumSHA3_256(p []byte) (sum [32]byte) { | ||
| if err := hashOneShot(bcrypt.SHA3_256_ALGORITHM, p, sum[:]); err != nil { | ||
| panic("bcrypt: SHA3_256 failed") |
There was a problem hiding this comment.
The error message should include the algorithm name to make it clear which algorithm failed.
| panic("bcrypt: SHA3_256 failed") | |
| panic("bcrypt: SHA3_256 failed for algorithm " + bcrypt.SHA3_256_ALGORITHM) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| // SumSHA3_384 returns the SHA3-384 checksum of the data. | ||
| func SumSHA3_384(p []byte) (sum [48]byte) { | ||
| if err := hashOneShot(bcrypt.SHA3_384_ALGORITHM, p, sum[:]); err != nil { | ||
| panic("bcrypt: SHA3_384 failed") |
There was a problem hiding this comment.
The error message should include the algorithm name to make it clear which algorithm failed.
| panic("bcrypt: SHA3_384 failed") | |
| panic("bcrypt: SHA3_384 failed for algorithm " + bcrypt.SHA3_384_ALGORITHM) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| // SumSHA3_512 returns the SHA3-512 checksum of the data. | ||
| func SumSHA3_512(p []byte) (sum [64]byte) { | ||
| if err := hashOneShot(bcrypt.SHA3_512_ALGORITHM, p, sum[:]); err != nil { | ||
| panic("bcrypt: SHA3_512 failed") |
There was a problem hiding this comment.
The error message should include the algorithm name to make it clear which algorithm failed.
| panic("bcrypt: SHA3_512 failed") | |
| panic("bcrypt: SHA3_512 failed for algorithm " + bcrypt.SHA3_512_ALGORITHM) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -16,6 +16,9 @@ import ( | |||
| "github.com/microsoft/go-crypto-winnative/internal/bcrypt" | |||
| ) | |||
|
|
|||
| // maxHashSize is the size of SHA52 and SHA3_512, the largest hashes we support. | |||
There was a problem hiding this comment.
The comment has a typo. It should be 'SHA512' instead of 'SHA52'.
| // maxHashSize is the size of SHA52 and SHA3_512, the largest hashes we support. | |
| // maxHashSize is the size of SHA512 and SHA3_512, the largest hashes we support. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Go 1.24 will ship with CSHAKE support. We need to follow suit.
Tests cases are taken from the standard library.
All SHA3 algorithms, which includes CSHAKE, are available since Windows 11, build 25324: https://blogs.windows.com/windows-insider/2023/03/23/announcing-windows-11-insider-preview-build-25324/#:~:text=Introducing%20SHA%2D3%20Support
While here, I've refactor the NewSHA3_256, NewSHA3_384, and NewSHA3_512 functions to return a concret type (SHA3) instead of the interface hash.Hash. This aligns with how upstream implemented
crypto/sha3, making the integration easier.For microsoft/go#1448.