Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-utilities): add autoCorrect and minLength input properties support to getNativeProps utility #33642

Merged
merged 3 commits into from
Jan 14, 2025
Merged

fix(react-utilities): add autoCorrect and minLength input properties support to getNativeProps utility #33642

merged 3 commits into from
Jan 14, 2025

Conversation

dmytrokirpa
Copy link
Contributor

Previous Behavior

autoCorrect and minLength prop were not considered as input props by getNativeProps utility and as a result were not forwarded to the native input/textarea elements by default.

New Behavior

Added autoCorrect and minLength props to getNativeProps utility configuration to make them available as input props.

Related Issue(s)

@dmytrokirpa dmytrokirpa self-assigned this Jan 14, 2025
@dmytrokirpa dmytrokirpa requested review from a team as code owners January 14, 2025 06:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)		 107.08 kB
32.786 kB		 107.106 kB
32.792 kB		 26 B
6 B
react-avatar
Avatar		 49.303 kB
15.815 kB		 49.329 kB
15.824 kB		 26 B
9 B
react-avatar
AvatarGroup		 20.106 kB
7.968 kB		 20.132 kB
7.976 kB		 26 B
8 B
react-avatar
AvatarGroupItem		 63.447 kB
20.034 kB		 63.473 kB
20.043 kB		 26 B
9 B
react-badge
Badge		 25.954 kB
8.595 kB		 25.98 kB
8.602 kB		 26 B
7 B
react-badge
CounterBadge		 26.733 kB
8.872 kB		 26.759 kB
8.879 kB		 26 B
7 B
react-badge
PresenceBadge		 25.719 kB
9.457 kB		 25.745 kB
9.463 kB		 26 B
6 B
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.291 kB
31.695 kB		 114.317 kB
31.702 kB		 26 B
7 B
react-button
Button		 37.174 kB
10.803 kB		 37.2 kB
10.811 kB		 26 B
8 B
react-button
CompoundButton		 43.588 kB
12.101 kB		 43.614 kB
12.109 kB		 26 B
8 B
react-button
MenuButton		 41.989 kB
12.144 kB		 42.015 kB
12.152 kB		 26 B
8 B
react-button
SplitButton		 50.006 kB
13.716 kB		 50.032 kB
13.724 kB		 26 B
8 B
react-button
ToggleButton		 53.107 kB
12.561 kB		 53.133 kB
12.569 kB		 26 B
8 B
react-card
Card - All		 101.77 kB
28.772 kB		 101.796 kB
28.779 kB		 26 B
7 B
react-card
Card		 94.544 kB
26.951 kB		 94.57 kB
26.957 kB		 26 B
6 B
react-card
CardFooter		 14.355 kB
5.79 kB		 14.381 kB
5.799 kB		 26 B
9 B
react-card
CardHeader		 16.888 kB
6.669 kB		 16.914 kB
6.677 kB		 26 B
8 B
react-card
CardPreview		 14.42 kB
5.922 kB		 14.446 kB
5.929 kB		 26 B
7 B
react-checkbox
Checkbox		 35.118 kB
12.077 kB		 35.144 kB
12.085 kB		 26 B
8 B
react-color-picker-preview
ColorArea		 50.263 kB
17.553 kB		 50.289 kB
17.561 kB		 26 B
8 B
react-color-picker-preview
ColorPicker		 32.22 kB
11.925 kB		 32.246 kB
11.934 kB		 26 B
9 B
react-color-picker-preview
ColorSlider		 41.577 kB
15.42 kB		 41.603 kB
15.429 kB		 26 B
9 B
react-combobox
Combobox (including child components)		 105.536 kB
34.512 kB		 105.562 kB
34.52 kB		 26 B
8 B
react-combobox
Dropdown (including child components)		 106.16 kB
34.454 kB		 106.186 kB
34.462 kB		 26 B
8 B
react-components
react-components: Button, FluentProvider & webLightTheme		 69.21 kB
20.174 kB		 69.236 kB
20.182 kB		 26 B
8 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 222.703 kB
64.42 kB		 222.729 kB
64.426 kB		 26 B
6 B
react-components
react-components: FluentProvider & webLightTheme		 44.447 kB
14.59 kB		 44.473 kB
14.597 kB		 26 B
7 B
react-components
react-components: entire library		 1.164 MB
291.232 kB		 1.164 MB
291.241 kB		 26 B
9 B
react-datepicker-compat
DatePicker Compat		 225.318 kB
63.786 kB		 225.344 kB
63.793 kB		 26 B
7 B
react-dialog
Dialog (including children components)		 100.417 kB
30.097 kB		 100.443 kB
30.105 kB		 26 B
8 B
react-divider
Divider		 21.328 kB
7.953 kB		 21.354 kB
7.963 kB		 26 B
10 B
react-field
Field		 23.399 kB
8.898 kB		 23.425 kB
8.905 kB		 26 B
7 B
react-image
Image		 15.36 kB
6.236 kB		 15.386 kB
6.243 kB		 26 B
7 B
react-input
Input		 28.014 kB
9.444 kB		 28.04 kB
9.451 kB		 26 B
7 B
react-label
Label		 14.671 kB
5.99 kB		 14.697 kB
5.999 kB		 26 B
9 B
react-link
Link		 17.326 kB
7.032 kB		 17.352 kB
7.04 kB		 26 B
8 B
react-list
List		 89.164 kB
26.599 kB		 89.19 kB
26.607 kB		 26 B
8 B
react-list
ListItem		 112.731 kB
33.432 kB		 112.757 kB
33.441 kB		 26 B
9 B
react-menu
Menu (including children components)		 154.048 kB
46.506 kB		 154.074 kB
46.514 kB		 26 B
8 B
react-menu
Menu (including selectable components)		 156.729 kB
46.992 kB		 156.755 kB
47 kB		 26 B
8 B
react-message-bar
MessageBar (all components)		 24.825 kB
9.267 kB		 24.851 kB
9.276 kB		 26 B
9 B
react-persona
Persona		 56.194 kB
17.695 kB		 56.22 kB
17.704 kB		 26 B
9 B
react-popover
Popover		 130.294 kB
40.69 kB		 130.32 kB
40.699 kB		 26 B
9 B
react-progress
ProgressBar		 17.084 kB
6.891 kB		 17.11 kB
6.899 kB		 26 B
8 B
react-provider
FluentProvider		 24.623 kB
8.893 kB		 24.649 kB
8.902 kB		 26 B
9 B
react-radio
Radio		 32.672 kB
10.343 kB		 32.698 kB
10.351 kB		 26 B
8 B
react-radio
RadioGroup		 15.762 kB
6.423 kB		 15.788 kB
6.431 kB		 26 B
8 B
react-select
Select		 27.732 kB
10.124 kB		 27.758 kB
10.131 kB		 26 B
7 B
react-slider
Slider		 37.52 kB
12.621 kB		 37.546 kB
12.631 kB		 26 B
10 B
react-spinbutton
SpinButton		 34.839 kB
11.63 kB		 34.865 kB
11.639 kB		 26 B
9 B
react-spinner
Spinner		 25.245 kB
8.539 kB		 25.271 kB
8.547 kB		 26 B
8 B
react-swatch-picker
@fluentui/react-swatch-picker - package		 105.086 kB
30.516 kB		 105.112 kB
30.526 kB		 26 B
10 B
react-switch
Switch		 35.319 kB
11.314 kB		 35.345 kB
11.322 kB		 26 B
8 B
react-table
DataGrid		 161.034 kB
45.71 kB		 161.06 kB
45.718 kB		 26 B
8 B
react-table
Table (Primitives only)		 42.666 kB
13.854 kB		 42.692 kB
13.862 kB		 26 B
8 B
react-table
Table as DataGrid		 131.869 kB
36.57 kB		 131.895 kB
36.579 kB		 26 B
9 B
react-table
Table (Selection only)		 70.536 kB
19.999 kB		 70.562 kB
20.007 kB		 26 B
8 B
react-table
Table (Sort only)		 69.179 kB
19.61 kB		 69.205 kB
19.618 kB		 26 B
8 B
react-tag-picker
@fluentui/react-tag-picker - package		 185.227 kB
55.684 kB		 185.253 kB
55.693 kB		 26 B
9 B
react-tags
InteractionTag		 15.199 kB
6.157 kB		 15.225 kB
6.165 kB		 26 B
8 B
react-tags
Tag		 29.072 kB
9.55 kB		 29.098 kB
9.559 kB		 26 B
9 B
react-tags
TagGroup		 82.719 kB
24.524 kB		 82.745 kB
24.532 kB		 26 B
8 B
react-text
Text - Default		 17.061 kB
6.723 kB		 17.087 kB
6.731 kB		 26 B
8 B
react-text
Text - Wrappers		 20.242 kB
7.048 kB		 20.268 kB
7.055 kB		 26 B
7 B
react-textarea
Textarea		 26.572 kB
9.755 kB		 26.598 kB
9.761 kB		 26 B
6 B
react-timepicker-compat
TimePicker		 108.525 kB
36.087 kB		 108.551 kB
36.094 kB		 26 B
7 B
react-toast
Toast (including Toaster)		 101.371 kB
30.477 kB		 101.397 kB
30.485 kB		 26 B
8 B
react-tree
FlatTree		 145.462 kB
41.771 kB		 145.488 kB
41.779 kB		 26 B
8 B
react-tree
PersonaFlatTree		 146.15 kB
41.881 kB		 146.176 kB
41.89 kB		 26 B
9 B
react-tree
PersonaTree		 142.381 kB
40.703 kB		 142.407 kB
40.711 kB		 26 B
8 B
react-tree
Tree		 141.693 kB
40.602 kB		 141.719 kB
40.611 kB		 26 B
9 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
react-aria
ARIA - Default		 237 B
181 B
react-calendar-compat
Calendar Compat		 150.095 kB
40.026 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.771 kB
1.643 kB
react-jsx-runtime
JSX Runtime		 4.367 kB
1.874 kB
react-motion
@fluentui/react-motion - createMotionComponent()		 4.434 kB
1.935 kB
react-motion
@fluentui/react-motion - createPresenceComponent()		 5.165 kB
2.263 kB
react-motion
@fluentui/react-motion - PresenceGroup		 1.714 kB
819 B
react-overflow
hooks only		 12.808 kB
4.819 kB
react-portal
Portal		 14.563 kB
5.118 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-positioning
usePositioning		 28.144 kB
10.046 kB
react-teaching-popover
TeachingPopover		 91.711 kB
27.921 kB
react-tooltip
Tooltip		 57.131 kB
19.949 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 5964b11d0ac272f2ae10e1081b8f0d1e17497eef

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

bsunderhus
bsunderhus approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@bsunderhus bsunderhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM 👍🏻

packages/react-components/react-utilities/src/utils/properties.ts Show resolved Hide resolved
@dmytrokirpa dmytrokirpa merged commit 8cf401d into microsoft:master Jan 14, 2025
16 checks passed
@dmytrokirpa dmytrokirpa deleted the fix/add-input-props-to-utilities branch January 14, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mainframev mainframev mainframev approved these changes

@bsunderhus bsunderhus bsunderhus approved these changes

Assignees

@dmytrokirpa dmytrokirpa

Labels
Component: Input Component: Textarea Textarea component. Fluent UI react-components (v9) Package: utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing autoCorrect and minLength properties in inputProperties and textAreaProperties
3 participants
@dmytrokirpa @bsunderhus @mainframev