-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InfoButton] New component #2874
base: dev
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
I see I somehow ended up creating a PR of my development branch to this development branch... I wanted to create a PR specific to the branch I used in my own fork... Sorry, I am a bit new to Github and forking of repo's and such.. |
This component must be accessible (you can use NVDA to validate it).
InfoButton.mp4Source: https://fluent2.microsoft.design/components/web/react/infolabel/usage |
Sadly, I won't be able to contribute to this, as I learned from company policies.. Sorry! Shall I close this PR or leave it open for someone else to pick it up? |
Leave it open please |
Pull Request
📖 Description
@franklupo did most of the work on this! I'll try to fill in the blanks that he was unable to pick up so far, as discussed in the previous PR #2332. So far the work I have added:
Added the missing unit tests for each property that is settable by end users.
Added a aria-hidden attribute that is set to true by default. I was not sure if this should be a settable property?
🎫 Issues
Like stated, most of the work in here was already done in #2332
✅ Checklist
General
Component-specific
⏭ Next Steps
I was not entirely sure which open recommendations were still actually 'open' in the previous pull request, so I would like to address those if any are left!