Skip to content

Commit

Permalink
fix: a race condition in Host.resetAllServices (#182)
Browse files Browse the repository at this point in the history
Fix a race condition in Host.resetAllServices() caused by calling
channel.close() as a callback of grpc.Client.waitForReady().

The root cause is gRPC subchannel pool state could become into
invalid state when global subchannel pool state is used, and there are
multiple channels used the same subchannel from the pool.

Closing the channel inside of waitForReady callback prevent all the
remaining callbacks for the subchannel from the correct state transition
handling.

Closing the channel inside of waitForReady callback prevents
the subchannel's remaining callbacks from the correct state transition handling.

The fix is to use setImmediate to allow the remaining callbacks for the
subchannel to process the state transition.
  • Loading branch information
Hexta authored Jul 28, 2023
1 parent d9013a8 commit eb99050
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/connection-pool.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export class Host {
// workaround: https://github.com/grpc/grpc-node/issues/1487
const state = service.getChannel().getConnectivityState(false);
if (state === grpc.connectivityState.CONNECTING) {
service.waitForReady(Date.now() + 10_00, () => service.close());
service.waitForReady(Date.now() + 10_00, () => setImmediate(() => service.close()));
} else {
service.close();
}
Expand Down

0 comments on commit eb99050

Please sign in to comment.