Commits on Jun 11, 2017

1. Fix to handle app name specifications with slashes. The is the CLI ... …

   change to match the corresponding server change deployed
   a couple days back.
   
   Here are details of the issue:
   // IIS and Azure web apps have this annoying behavior where %2F (URL encoded slashes) in the URL are URL decoded
   // BEFORE the requests reach node. That essentially means there's no good way to encode a "/" in the app name--
   // URL encodeing will work when running locally but when running on Azure it gets decoded before express sees it,
   // so app names with slashes don't get routed properly. See tjanczuk/iisnode#343 (or other sites
   // that complain about the same) for some more info. I explored some IIS config based workarounds, but the previous
   // link seems to say they won't work, so I eventually gave up on that.
   // Anyway, to workaround this issue, we now allow the client to encode / characters as ~~ (two tildes, URL encoded).
   // The CLI now converts / to ~~ if / appears in an app name, before passing that as part of the URL. This code below
   // does the encoding. It's hack, but seems like the least bad option here.
   // Eventually, this service will go away & we'll all be on Max's new service. That's hosted in docker, no more IIS,
   // so this issue should go away then.

   

   BretJohnson committed Jun 11, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 79b591c
   • Browse repository at this point

   Copy the full SHA

   79b591c View commit details

   Browse the repository at this point in the history