Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GCA fluid models #8

Merged
merged 3 commits into from
Aug 30, 2023
Merged

add GCA fluid models #8

merged 3 commits into from
Aug 30, 2023

Conversation

DavidRuhe
Copy link
Contributor

No description provided.

rejuvyesh
rejuvyesh approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@rejuvyesh rejuvyesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be useful to document it a little so we can add them to auto-generated docs.

cliffordlayers/models/gca_models_2d.py Outdated

def get_activation(activation: str, channels: int) -> Callable:
if activation == "vsum":
return lambda x: torch.sigmoid(x.sum(-1, keepdim=True)) * x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably make proper nn.Modules for these as they were quite useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@DavidRuhe
Copy link
Contributor Author

Added docstrings.

@rejuvyesh rejuvyesh merged commit 37c0939 into microsoft:main Aug 30, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejuvyesh rejuvyesh rejuvyesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidRuhe @rejuvyesh