Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better naming of customized models #7

Merged
merged 2 commits into from
Aug 11, 2023
Merged

better naming of customized models #7

merged 2 commits into from
Aug 11, 2023

Conversation

brandstetter-johannes
Copy link
Contributor

do some renaming such that MaxwellNet from custom_models is directly applicable to pdearena

rejuvyesh
rejuvyesh approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@rejuvyesh rejuvyesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we should add some explanation somewhere what are the specific choices being made that they are not general purpose layers at the moment? Or can we name them differently to point out they are vector-bivector etc.

@rejuvyesh rejuvyesh merged commit a875790 into main Aug 11, 2023
1 of 5 checks passed
@rejuvyesh rejuvyesh deleted the better_naming branch August 11, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejuvyesh rejuvyesh rejuvyesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandstetter-johannes @rejuvyesh