Remove mkinitrd script. #8126
Merged
Remove mkinitrd script. #8126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwize1
commented
Feb 28, 2024
PawelWMS
approved these changes
Feb 28, 2024
ddstreetmicrosoft
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Several things, most importantly we definitely need to revisit the (incomplete) kexec-tools upgrade, and we absolutely need to make sure kdump is not using the system initrd.
I'd also like to understand why we have the initramfs package at all.
Finally, that kernel-rt grub config stuff almost certainly is no longer needed and should be removed.
cwize1
force-pushed
the
user/chrisgun/RenameToInitramfs
branch
2 times, most recently
from
78ade9a
to
59e9bd0
Compare
ddstreetmicrosoft
approved these changes
Feb 29, 2024
Camelron
approved these changes
Feb 29, 2024
This changes removes the mkinitrd script and replaces all calls with direct calls to dracut. In addition, the /boot/initrd.img-<kver> file has been renamed to /boot/initramfs-<kver>.img to match the default name used by dracut. This avoids needing to add a patch to dracut to change the default name of the initrd file. Also, previously the mkinitrd script passed the `--hostonly` flag to dracut to ensure the hostonly option was enabled. This has been replaced with setting the hostonly only in the `/etc/dracut.conf` file instead. One nice advantage this provides is that it allows a user to override this default by adding a config file under the `/etc/dracut.conf.d` directory.
cwize1
force-pushed
the
user/chrisgun/RenameToInitramfs
branch
from
59e9bd0
to
e8681b6
Compare
dmcilvaney
approved these changes
Feb 29, 2024
cwize1
added a commit
that referenced
this pull request
Mar 6, 2024
In change #8126, the mkinitrd script was removed in favor of using dracut directly. However, one feature that was missed was that the mkinitrd script pulls additional dracut settings from files under the /var/lib/initramfs/kernel directory. This was being used to add the VM guest drivers to initramfs file. Since these drivers are no longer being added, the images don't boot under Hyper-V. This change re-adds the guest VM drivers to dracut, but using the /etc/dracut.conf.d config directory.
12 tasks
13 tasks
|
A message from dracut upstream regarding the intention of standardizing the naming of the generated initramfs. dracut-ng/dracut-ng#160 You should perhaps consider keeping the initrd-$KVER naming schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
This changes removes the mkinitrd script and replaces all calls with direct calls to dracut.
In addition, the /boot/initrd.img- file has been renamed to /boot/initramfs-.img to match the default name used by dracut. This avoids needing to add a patch to dracut to change the default name of the initrd file.
Also, previously the mkinitrd script passed the
--hostonlyflag to dracut to ensure the hostonly option was enabled. This has been replaced with setting the hostonly only in the/etc/dracut.conffile instead. One nice advantage this provides is that it allows a user to override this default by adding a config file under the/etc/dracut.conf.ddirectory.Change Log
/boot/initrd.img-<kver>to/boot/initramfs-<kver>.img.hostonlytoyesin/etc/dracut.conf.Does this affect the toolchain?
YES, but only a kernel-headers version bump.
Test Methodology