-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mkinitrd script. #8126
Remove mkinitrd script. #8126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The toolkit changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several things, most importantly we definitely need to revisit the (incomplete) kexec-tools
upgrade, and we absolutely need to make sure kdump
is not using the system initrd.
I'd also like to understand why we have the initramfs
package at all.
Finally, that kernel-rt
grub config stuff almost certainly is no longer needed and should be removed.
78ade9a
to
59e9bd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely multiple issues with our overall setup but as you pointed out you're not trying to fix everything in this pr, just make a minor tweak, and that tweak looks fine (mostly), and i'll try to keep track of the existing issues and fix in separate prs
This changes removes the mkinitrd script and replaces all calls with direct calls to dracut. In addition, the /boot/initrd.img-<kver> file has been renamed to /boot/initramfs-<kver>.img to match the default name used by dracut. This avoids needing to add a patch to dracut to change the default name of the initrd file. Also, previously the mkinitrd script passed the `--hostonly` flag to dracut to ensure the hostonly option was enabled. This has been replaced with setting the hostonly only in the `/etc/dracut.conf` file instead. One nice advantage this provides is that it allows a user to override this default by adding a config file under the `/etc/dracut.conf.d` directory.
59e9bd0
to
e8681b6
Compare
In change #8126, the mkinitrd script was removed in favor of using dracut directly. However, one feature that was missed was that the mkinitrd script pulls additional dracut settings from files under the /var/lib/initramfs/kernel directory. This was being used to add the VM guest drivers to initramfs file. Since these drivers are no longer being added, the images don't boot under Hyper-V. This change re-adds the guest VM drivers to dracut, but using the /etc/dracut.conf.d config directory.
A message from dracut upstream regarding the intention of standardizing the naming of the generated initramfs. dracut-ng/dracut-ng#160 You should perhaps consider keeping the initrd-$KVER naming schema. |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
This changes removes the mkinitrd script and replaces all calls with direct calls to dracut.
In addition, the /boot/initrd.img- file has been renamed to /boot/initramfs-.img to match the default name used by dracut. This avoids needing to add a patch to dracut to change the default name of the initrd file.
Also, previously the mkinitrd script passed the
--hostonly
flag to dracut to ensure the hostonly option was enabled. This has been replaced with setting the hostonly only in the/etc/dracut.conf
file instead. One nice advantage this provides is that it allows a user to override this default by adding a config file under the/etc/dracut.conf.d
directory.Change Log
/boot/initrd.img-<kver>
to/boot/initramfs-<kver>.img
.hostonly
toyes
in/etc/dracut.conf
.Does this affect the toolchain?
YES, but only a kernel-headers version bump.
Test Methodology