Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple R example #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add simple R example #18

wants to merge 5 commits into from

Conversation

bstabler
Copy link

#17

@chrispat
Copy link
Contributor

chrispat commented Nov 1, 2018

Wouldn't it make more sense to rely on the r docker container here instead of installing?

https://hub.docker.com/_/r-base/
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=vsts&tabs=yaml

@vtbassmatt
Copy link
Member

@bstabler given your +1 to Chris's comment, are you going to switch to a container approach? If not, I'll close this for now.

@bstabler
Copy link
Author

I think both examples are useful. How about I (or someone else) add a docker version as well?

@vtbassmatt
Copy link
Member

The templates are intended to show the canonical / most common way, not to provide options. A pattern we've used before is to keep the template simple but point to a language guide in our docs (for example, Python) that goes into more detail. We take doc PRs in another repo if that's a line you want to pursue.

@bstabler
Copy link
Author

I updated the example to use the R docker container, thanks.

@lorenzwalthert
Copy link

Why have you removed the R package installation example? I think it could be pretty informative and also, everyone will want to install packages. I am struggling at the moment to get R package installed in the pipeline. I checked rocker-org/rocker-versioned#108 and then tried to make the folder 777, but I did not have sufficient permission.

@nickforr
Copy link

Hi,

If you're looking for an example for installing packages, I'd suggest adopting the same approach as is in the rocker images (using install2.r from Dirk's littler library). For example, from the tidyverse container in rocker:

install2.r --error \
    --deps TRUE \
    tidyverse \
    dplyr \
    devtools \
    formatR \
    remotes \
    selectr \
    caTools \
    BiocManager

@vtbassmatt
Copy link
Member

Hey all. We don't have an R expert or champ internal to the team. Does the PR as it currently exists look good? If a couple of you want to give me a thumbs-up, I'll be happy to merge it. Otherwise, I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants