Fixing codeQL bugs :Updating hash algorithm #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navya9singh
commented
Jan 30, 2025
navya9singh
added
the
deploy-preview
jakebailey
requested changes
Jan 30, 2025
| @@ -96,7 +96,7 @@ langs.forEach(lang => { | |||
| .replace(/\+/g, "-"), | |||
|
|
|||
| sortIndex: index, | |||
| hash: crypto.createHash("md5").update(contents).digest("hex"), | |||
| hash: crypto.createHash("sha512").update(contents).digest("hex"), | |||
There was a problem hiding this comment.
Checking this, the website still works fine here. It's put into data-hash in ShowExamples and that's just used to cache loading them.
Co-authored-by: Jake Bailey <[email protected]>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3318.centralus.5.azurestaticapps.net |
jakebailey
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes https://liquid.microsoft.com/codeql/issues/554838ed-6abd-48f1-bfa9-03546781e3c1?copilot_promptid=E91B0CE9-0C1B-4AC2-8A46-33F49B67E058 and https://liquid.microsoft.com/codeql/issues/df74a67a-14d7-41b4-9ed2-b8e9c2a184cb?copilot_promptid=E91B0CE9-0C1B-4AC2-8A46-33F49B67E058
Reference: https://liquid.microsoft.com/Web/Object/Read/MS.Security/Requirements/Microsoft.Security.Cryptography.10021#Zguidance