Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardizing the TypeScript name in Portuguese documentation #126

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

yuriwithowsky
Copy link
Contributor

Standardizing the TypeScript name in Portuguese documentations.

@ghost
Copy link

ghost commented Nov 18, 2021

CLA assistant check
All CLA requirements met.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @khaosdoctor and @danilofuchs - if they write a comment saying "LGTM" then it will be merged.

Copy link
Contributor

@danilofuchs danilofuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!

LGTM

@khaosdoctor
Copy link
Contributor

It seems we're having a file misplaced here, I'll take a look

@khaosdoctor
Copy link
Contributor

@yuriwithowsky can you please rebase the master branch onto yours and re-push it so we can run the checks again?

@yuriwithowsky
Copy link
Contributor Author

@yuriwithowsky can you please rebase the master branch onto yours and re-push it so we can run the checks again?

Done!

Copy link
Contributor

@danilofuchs danilofuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuriwithowsky
Copy link
Contributor Author

broken again 😞

@danilofuchs
Copy link
Contributor

@orta could you help us?

@orta
Copy link
Contributor

orta commented Mar 23, 2022

Hrm, I don't have merge rights anymore - might be worth giving it another try as it seems to be pretty arbitrary OSS-Docs-Tools/code-owner-self-merge#35

@danilofuchs
Copy link
Contributor

Ok!
🤞
LGTM

@github-actions github-actions bot merged commit 6816315 into microsoft:main Mar 23, 2022
@github-actions
Copy link
Contributor

Merging because @danilofuchs is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants