Deprecation message for legacy telemetry #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/Activities.UnitTests/Internal/ActivitiesEventSourceTests.cs
Outdated
Show resolved
Hide resolved
added 2 commits
May 10, 2024 16:20
K-Cully
reviewed
May 13, 2024
K-Cully
reviewed
May 13, 2024
K-Cully
reviewed
May 13, 2024
artempushkin
requested changes
May 13, 2024
src/ServiceFabricGuest.Abstractions/ServiceFabricClientFactory.cs
Outdated
Show resolved
Hide resolved
added 2 commits
May 13, 2024 17:51
K-Cully
reviewed
May 17, 2024
K-Cully
reviewed
May 17, 2024
K-Cully
reviewed
May 17, 2024
…ing_legacy_telemetry' into dothanhl/feature/depreacate_warning_legacy_telemetry
artempushkin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change?
This change is the first enforcement to warn consumers that
OmexLogger.csandActivityEventSender.csare no longer maintained and ready for removal by 1 July 2024.What is changed in this PR?
For logging: files related to
OmexLogger.csand this event sourceMicrosoft-OMEX-Logs-Extare marked Obsolete.For metrics: file related to
ActivityEventSender.csand this event sourceMicrosoft-OMEX-TimedScopes-Extare marked Obsolete.What to prepare by 1 July 2024
We will put stronger enforcement to disable OmexLogger and ActivityEventSender. Upcoming change are
For logging: Consumers need to find an alternative way to register a new log provider for now. Omex will try to ship OpenTelemetry logger in the future as default logger.
For metrics: Consumers can rely on existing
ActivityMetricSender.csto get metrics by OpenTelemetry metric sdk. Consumers are recommended and have your own metric exporter to transfer metrics to a destination, such as Azure Application Insight, a database like MSSQL or MongoDB, etc,.