Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package references while dual targeting #642

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix package references while dual targeting #642

merged 2 commits into from
Dec 5, 2023

Conversation

K-Cully
Copy link
Member

@K-Cully K-Cully commented Dec 5, 2023

We were referencing .NET8 packages in .NET7 binaries which caused package conflicts for downstream consumers still targeting Net7.
This PR addresses the package reference issue by:

  • Adding conditional package includes based on target framework.
  • Adds some convenience build properties to simplify future dual-targeting changes.

@K-Cully K-Cully requested a review from a team as a code owner December 5, 2023 13:38
@K-Cully K-Cully enabled auto-merge (squash) December 5, 2023 13:56
manio143
manio143 reviewed Dec 5, 2023
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
@K-Cully K-Cully merged commit 09bc06c into main Dec 5, 2023
5 checks passed
@K-Cully K-Cully deleted the k-cully/fix-dual-target-package-refs branch December 5, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manio143 manio143 manio143 approved these changes

@MaxDac MaxDac MaxDac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@K-Cully @manio143 @MaxDac