Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled options to disable Omex telemetry via config #614

Merged
merged 7 commits into from
Oct 20, 2023

Conversation

artempushkin
Copy link
Contributor

@artempushkin artempushkin commented Oct 18, 2023

This opens the way to disable Omex telemetry implementations.

OmexLogger can be controlled by standard logging configuration, usually found in appsettings.json. Option class to disable generation of TimedScope metrics from Activities already existed, binding was improved with validation on start.

To disable both logs and activity metrics, put the following in appsettings.json:

{
  "Monitoring": {
    "ActivityEventSenderEnabled": false
  },
  "Logging": {
    "Omex": {
      "LogLevel": {
        "Default": "None"
      }
    }
  }
}

Initialization logger for now remains enabled, its usage should be reduced first.

@artempushkin artempushkin requested a review from a team as a code owner October 18, 2023 23:24
@artempushkin artempushkin merged commit 46d4aff into main Oct 20, 2023
5 checks passed
@artempushkin artempushkin deleted the arpushki-omex-telemetry-killswitch branch October 20, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants