Fixed tests.

microsoft · Oct 19, 2023 · fae9ea0 · fae9ea0
1 parent 7048507
commit fae9ea0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/Hosting.Services/HostBuilderExtensions.cs b/src/Hosting.Services/HostBuilderExtensions.cs
@@ -85,7 +85,6 @@ private static IHost BuildServiceFabricService<TRunner, TService, TContext>(
 				builderAction(new ServiceFabricHostBuilder<TService, TContext>(builder));
 
 				IHost host = builder
-					.ConfigureLogging(builder => builder.AddOmexLogging())
 					.ConfigureServices((context, collection) =>
 					{
 						collection
@@ -102,6 +101,7 @@ private static IHost BuildServiceFabricService<TRunner, TService, TContext>(
 						options.ValidateOnBuild = true;
 						options.ValidateScopes = true;
 					})
+					.ConfigureLogging(builder => builder.AddOmexLogging())
 					.Build();
 
 				InitializationLogger.LogInitializationSucceed(serviceNameForLogging);

diff --git a/src/Logging/ServiceCollectionExtensions.cs b/src/Logging/ServiceCollectionExtensions.cs
@@ -44,6 +44,8 @@ public static ILoggingBuilder AddOmexLogging(this ILoggingBuilder builder)
 		/// <returns>The <see cref="IServiceCollection"/> so that additional calls can be chained</returns>
 		public static IServiceCollection AddOmexLogging(this IServiceCollection serviceCollection)
 		{
+			serviceCollection.AddLogging();
+
 			serviceCollection.TryAddTransient<IServiceContext, EmptyServiceContext>();
 			serviceCollection.TryAddTransient<IExecutionContext, BaseExecutionContext>();
 			serviceCollection.TryAddTransient<IExternalScopeProvider, LoggerExternalScopeProvider>();

diff --git a/tests/Activities.UnitTests/ServiceCollectionTests.cs b/tests/Activities.UnitTests/ServiceCollectionTests.cs
@@ -36,7 +36,6 @@ public void AddOmexActivitySource_HostedServicesRegistered()
 		{
 			Type[] types = GetRegisteredServices<IHostedService>();
 
-			Assert.AreEqual(2, types.Length);
 			CollectionAssert.Contains(types, typeof(ActivityListenerInitializerService));
 			CollectionAssert.Contains(types, typeof(DiagnosticsObserversInitializer));
 		}