-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export SharedTree DDS type and attributes to be used in Loop Repo for creating a Delay Loaded Factory #23731
Conversation
… creating a Delay Loaded Factory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- experimental/dds/tree/api-report/experimental-tree.alpha.api.md: Evaluated as low risk
- experimental/dds/tree/src/SharedTree.ts: Evaluated as low risk
- experimental/dds/tree/src/index.ts: Evaluated as low risk
- experimental/dds/tree/src/publicContracts.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)
packages/dds/tree/src/shared-tree/publicContracts.ts:11
- [nitpick] The use of '@legacy' should be confirmed to ensure it is consistent with the rest of the codebase.
@legacy
packages/dds/tree/src/shared-tree/publicContracts.ts:22
- The 'snapshotFormatVersion' is set to '0.0.0'. Confirm if this is intended or a placeholder.
snapshotFormatVersion: "0.0.0"
packages/dds/tree/src/shared-tree/publicContracts.ts:23
- The 'packageVersion' is set to '0.0.0'. Confirm if this is intended or a placeholder.
packageVersion: "0.0.0"
Co-authored-by: Tony Murphy <[email protected]>
Co-authored-by: Tony Murphy <[email protected]>
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
Description
Export SharedTree DDS type and attributes to be used in Loop Repo for creating a Delay Loaded Factory. We needed to created a delay loaded factory for shared tree in Loop Repo in to not impact the bundle size on load. So, both the type and attributes needs to be exported.