Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export SharedTree DDS type and attributes to be used in Loop Repo for creating a Delay Loaded Factory #23731

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Jan 31, 2025

Description

Export SharedTree DDS type and attributes to be used in Loop Repo for creating a Delay Loaded Factory. We needed to created a delay loaded factory for shared tree in Loop Repo in to not impact the bundle size on load. So, both the type and attributes needs to be exported.

@jatgarg jatgarg requested review from pragya91 and vladsud January 31, 2025 20:12
@jatgarg jatgarg self-assigned this Jan 31, 2025
@Copilot Copilot bot review requested due to automatic review settings January 31, 2025 20:12
@jatgarg jatgarg requested review from a team as code owners January 31, 2025 20:12
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree public api change Changes to a public API base: main PRs targeted against main branch labels Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • experimental/dds/tree/api-report/experimental-tree.alpha.api.md: Evaluated as low risk
  • experimental/dds/tree/src/SharedTree.ts: Evaluated as low risk
  • experimental/dds/tree/src/index.ts: Evaluated as low risk
  • experimental/dds/tree/src/publicContracts.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)

packages/dds/tree/src/shared-tree/publicContracts.ts:11

  • [nitpick] The use of '@legacy' should be confirmed to ensure it is consistent with the rest of the codebase.
@legacy

packages/dds/tree/src/shared-tree/publicContracts.ts:22

  • The 'snapshotFormatVersion' is set to '0.0.0'. Confirm if this is intended or a placeholder.
snapshotFormatVersion: "0.0.0"

packages/dds/tree/src/shared-tree/publicContracts.ts:23

  • The 'packageVersion' is set to '0.0.0'. Confirm if this is intended or a placeholder.
packageVersion: "0.0.0"
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  160745 links
    1452 destination URLs
    1683 URLs ignored
       0 warnings
       0 errors


@jatgarg jatgarg merged commit 9f43f99 into microsoft:main Jan 31, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants