improvement(shared-object-base): use shallowCloneObject helper in FluidSerializer to clean up no-unsafe-assignment lint disable
#23717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
WillieHabi
changed the title
jason-ha
reviewed
Jan 31, 2025
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment -- TODO: not sure if there's a good solution | ||
| clone = clone ?? (Array.isArray(input) ? [...input] : { ...input }); | ||
| clone = clone ?? shallowCloneObject(input); |
There was a problem hiding this comment.
nit: we now prefer: clone ??= over clone = clone ??
jason-ha
approved these changes
Jan 31, 2025
WillieHabi
changed the title
Thanks my mistake. wrongly assumed those became unused after the change. |
WillieHabi
changed the title
WillieHabi
changed the title
no-unsafe-assignment lint disable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #23662: #23662 (comment)
Reason for
shallowCloneObject: #23662 (comment)This PR also removes several unused
no-unsafe-assignmentlint disables in test file serializer.spec.ts.