Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable no-unchecked-record-access for driver utils #23715

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Enable no-unchecked-record-access for driver utils #23715

wants to merge 6 commits into from
+0 −1

Conversation

RishhiB
Copy link
Contributor

@RishhiB RishhiB commented Jan 31, 2025

ESLint Configuration Changes:

  • Changed the rule for @fluid-internal/fluid/no-unchecked-record-access from "warn" to "error" in the .eslintrc.cjs file by removing the line

Needs Review:

  • Modified variable declarations in gitHelper.ts:
    • Updated node variable to include proper type annotation for potential undefined values (ISnapshotTreeEx | undefined)
  • Added ESLint disable comments in summaryCompressionTester.spec.ts where unchecked record access is necessary:
    • For header access in generateSummaryWithContent
    • For header access in generateSummaryWithBinaryContent
    • For header tree access in getHeader

@Copilot Copilot bot review requested due to automatic review settings January 31, 2025 17:00
@github-actions github-actions bot added area: loader Loader related issues base: main PRs targeted against main branch labels Jan 31, 2025
Copilot
Copilot AI reviewed Jan 31, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
@RishhiB RishhiB requested review from jason-ha and a team January 31, 2025 17:25
@github-actions github-actions bot removed the area: loader Loader related issues label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jason-ha jason-ha Awaiting requested review from jason-ha

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RishhiB