Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable no-unchecked-record-access for merge tree #23714

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Enable no-unchecked-record-access for merge tree #23714

wants to merge 5 commits into from
+0 −1

Conversation

RishhiB
Copy link
Contributor

@RishhiB RishhiB commented Jan 31, 2025

ESLint Configuration Changes:

  • Changed the rule for @fluid-internal/fluid/no-unchecked-record-access from "warn" to "error" in the .eslintrc.cjs file by removing the line

Needs Review:

  • Added ESLint disable comment in properties.ts for necessary unchecked record access during extension operations
  • Modified merge-tree's ESLint configuration to enable safer property access patterns

@Copilot Copilot bot review requested due to automatic review settings January 31, 2025 16:57
@RishhiB RishhiB requested a review from a team as a code owner January 31, 2025 16:57
@github-actions github-actions bot added the area: dds Issues related to distributed data structures label Jan 31, 2025
Copilot
Copilot AI reviewed Jan 31, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
@github-actions github-actions bot added the base: main PRs targeted against main branch label Jan 31, 2025
@RishhiB RishhiB requested review from jason-ha and a team January 31, 2025 17:25
@github-actions github-actions bot removed the area: dds Issues related to distributed data structures label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jason-ha jason-ha Awaiting requested review from jason-ha

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RishhiB