Merge pull request #1841 from microsoft/dpaul-HcUrlDataSigning

Show more info for data serialization signing when not set
microsoft · Oct 4, 2023 · 811f48c · 811f48c
2 parents 732e0cf + 4e6e971
commit 811f48c
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/...ics/HealthChecker/Analyzer/Security/Invoke-AnalyzerSecuritySerializedDataSigningState.ps1 b/...ics/HealthChecker/Analyzer/Security/Invoke-AnalyzerSecuritySerializedDataSigningState.ps1
@@ -100,10 +100,18 @@ function Invoke-AnalyzerSecuritySerializedDataSigningState {
         }
         Add-AnalyzedResultInformation @params
 
-        if ($null -ne $additionalSerializedDataSigningDisplayValue) {
+        # Always display if not true
+        if (-not ($serializedDataSigningState -eq $true)) {
+            $addLine = "This may pose a security risk to your servers`r`n`t`tMore Information: https://aka.ms/HC-SerializedDataSigning"
+
+            if ($null -ne $additionalSerializedDataSigningDisplayValue) {
+                $details = "$additionalSerializedDataSigningDisplayValue`r`n`t`t$addLine"
+            } else {
+                $details = $addLine
+            }
+
             $params = $baseParams + @{
-                Details                = $additionalSerializedDataSigningDisplayValue +
-                "`r`n`t`tThis may pose a security risk to your servers`r`n`t`tMore Information: https://aka.ms/HC-SerializedDataSigning"
+                Details                = $details
                 DisplayWriteType       = $serializedDataSigningWriteType
                 DisplayCustomTabNumber = 2
             }