Support reactive/future HTTP client bodies #11547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawkat
reviewed
Jan 28, 2025
| @@ -894,16 +896,21 @@ private <I, O, E> Mono<HttpResponse<O>> exchange(io.micronaut.http.HttpRequest<I | |||
| AtomicReference<ScheduledExecutorService> scheduler = new AtomicReference<>(connectionManager.getGroup()); | |||
| ExecutionFlow<HttpResponse<O>> mono = resolveRequestURI(request).flatMap(uri -> { | |||
| MutableHttpRequest<?> mutableRequest = toMutableRequest(request).uri(uri); | |||
| Object body = mutableRequest.getBody().orElse(null); | |||
| if (body instanceof Publisher<?> publisher) { | |||
| return ReactiveExecutionFlow.fromPublisher(publisher).flatMap(resolvedBody -> { | |||
There was a problem hiding this comment.
I think Publisher support also needs multi-element support.
There was a problem hiding this comment.
Not sure how we should support it
There was a problem hiding this comment.
My vote is that we don't for now. Actually mirroring the server behavior is more complicated than this. But this implementation is not workable, e.g. @Body Publisher<byte[]> will support streaming on the server but not on the client.
|
I don't really see how this is useful for the single-element case, cant you just do |
|
The problem that I’m trying to use an interface API definition, controller works fine but the client is missing this. |
|
Are all the failures related? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.