feat: Enhance VariableEditor to support BigNumber type handling #55
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| case 'bigNumber': | ||
| string_value = value.toString() | ||
| break |
There was a problem hiding this comment.
why not treat it as string at this level?
There was a problem hiding this comment.
The separate case for bigNumber is intentional - it helps distinguish between bigNumber and regular string types. This distinction is particularly useful when we need different display formats, allowing us to maintain consistent handling of bigNumber values while preserving the flexibility to format them either as bigNumber or strings based on the configuration, following the same pattern as the existing code.
There was a problem hiding this comment.
Added some comments; Additionally, you should to add it into the dev-server too
https://github.com/microlinkhq/react-json-view/blob/main/dev-server/src/index.js#L199
bigNumberproperty toReactJsonViewandVariableEditorcomponents.JsonBigNumbercomponent for rendering BigNumber values.parseInputandstringifyVariablefunctions to handle BigNumber parsing and stringification.toTypeutility function to recognize BigNumber instances.bigNumberproperty and its usage.This update improves the precision handling of numbers in the application.