Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of not being able to bind a PayPal account #2620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DaVinci9196
Copy link
Contributor

No description provided.

@mar-v-in
Copy link
Member

mar-v-in commented Nov 12, 2024

Using CustomTabsIntent means moving authentication tokens and cookies into the current browser, meaning you sign in the browser into a Google account even if the user doesn't want that.

@DaVinci9196
Copy link
Contributor Author

DaVinci9196 commented Nov 13, 2024

Using CustomTabsIntent means moving authentication tokens and cookies into the current browser, meaning you sign in the browser into a Google account even if the user doesn't want that.

Yes, but during use, I found that when I jump to the web page to add a payment method and view other content, an error page will be displayed.

@mar-v-in
Copy link
Member

You mean you can't add a PayPal account inside the WebView? There is a pending TODO in WebViewHelper to redirect some navigations to the browser, I guess that's what needs to be implemented correctly. It even shows a message shortly before the PayPal screen hinting that it should open an external browser:
ef53a37_mSEyeYGtSN-W6qCjq7MLiQ

@DaVinci9196
Copy link
Contributor Author

DaVinci9196 commented Nov 14, 2024

@mar-v-in I tried to click Add PayPal in the webview and then jump to the browser for subsequent operations, but when I clicked Return to the merchant (an error pop-up window appeared with account restriction), I could not return to the page before the jump (the page in the screenshot above).

Below is the normal process after using CustomTabsIntent. They have data interaction and cannot be separated.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants