Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues related to AuthSignIn page #2585

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix issues related to AuthSignIn page #2585

wants to merge 4 commits into from

Conversation

DaVinci9196
Copy link
Contributor

Fixed the issue that the account selection page is not fully displayed in landscape mode.
image

@mar-v-in
Copy link
Member

I think it would be better to have two layout files and have the resource manager pick the appropriate layout file based on viewport size.

@DaVinci9196
Copy link
Contributor Author

I think it would be better to have two layout files and have the resource manager pick the appropriate layout file based on viewport size.

Changed

mar-v-in
mar-v-in requested changes Nov 12, 2024
View reviewed changes
play-services-core/src/main/res/layout/signin_picker.xml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the changes in this file (as they're all just formatting, it showing up in the history will only cause confusion)

play-services-core/src/main/kotlin/org/microg/gms/auth/signin/AuthSignInActivity.kt Outdated Show resolved Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/auth/signin/AuthSignInActivity.kt Outdated Show resolved Hide resolved
play-services-core/src/main/res/layout-land/signin_picker.xml Outdated Show resolved Hide resolved
@mar-v-in mar-v-in added this to the 0.3.6 milestone Nov 12, 2024
@DaVinci9196
Copy link
Contributor Author

@mar-v-in Modified

@mar-v-in mar-v-in modified the milestones: 0.3.6, 0.3.5 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mar-v-in mar-v-in mar-v-in approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@DaVinci9196 @mar-v-in