Pydantic v2 upgrade #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linknum23
force-pushed
the
pydanticv2-upgrade
branch
2 times, most recently
from
ff25f18 to
e902583
Compare
linknum23
force-pushed
the
pydanticv2-upgrade
branch
from
e902583 to
572399e
Compare
|
@klay2000 can you give this a sanity check? No need to validate this. |
klay2000
requested changes
Jan 8, 2025
- Optional[] fields need to be initialized to None to actually be parsed as optional - __fields__ -> model_fields - json() -> model_dump_json() - parse_obj() -> model_validate()
linknum23
force-pushed
the
pydanticv2-upgrade
branch
from
28fb82d to
5724718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to a newer generation of pydantic. Initial changes followed the guide here: https://docs.pydantic.dev/latest/migration/
The major challenge here was pyamplipi's use of pydantic;'s ModelMetaclass and ModelField which were made private by the pydantic devs (for good reasons).
This code has been tested via: