-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Settings layout #999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while you're at it, can you align the textbox elements so they don't look haphazard?
imo, tooltips like this are not good design. they are less accessible than the alternative of just describing the feature below its heading, and still aren't actually obvious, even with your svg. |
051c721
to
001abbf
Compare
Marking this as "Not quite ready yet" due to this funny bug Recording.2024-12-06.154824.mp4 |
I have a few more CSS issues in this PR to iron out before it is ready for approval; the images are still valid means of judging the end product but the buttons seem to shrink after getting the loading spinner and success text |
43e00c2
to
7cadbb1
Compare
Problems solved, ready for review |
5aca651
to
477bd3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks better and the changes are fine at a glance code wise, I would just like the field descriptions to be a little more precise. I'll look at the code more closely once these are updated.
85c8852
to
771ee57
Compare
Update admin setting description wording Reword description
771ee57
to
7540074
Compare
What does this change intend to accomplish?
Indents subsections to make it more obvious that they are part of a given subheader, align buttons and textboxes, get rid of hoverover tooltips and add them to the top of settings subsections
Closes #998
Before:
After:
Checklist
./scripts/test