Preset and add creation #1015
Open
Preset and add creation #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMicroNova
commented
Jan 9, 2025
There was a problem hiding this comment.
TypeSelectModal and StreamModal are always used as a pair, so I packaged them as a pair for ease of use
SteveMicroNova
commented
Jan 9, 2025
There was a problem hiding this comment.
I liked the style of the add stream button on the home page and wanted to use it elsewhere, so I've packaged it into this component
SteveMicroNova
force-pushed
the
PresetAndAddCreation
branch
from
9b93cab to
49ffd03
Compare
SteveMicroNova
commented
Jan 10, 2025
Comment on lines
27
to
29
| <> | ||
| <Modal className="streams-modal" onClose={onClose}> | ||
| <Modal onClose={onClose}> | ||
| <Card className="type-select-card"> |
There was a problem hiding this comment.
This class wasn't declared in any CSS so I removed it
…ls into the components folder and reuse them on the home page
SteveMicroNova
force-pushed
the
PresetAndAddCreation
branch
from
49ffd03 to
9ed8b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change intend to accomplish?
Closes #707
Moved stream and preset creation workflows to the components folder, then spread them to relevant places (preset creation on presets settings page and presets modal on home page, stream creation in all places streams can be selected)
Checklist
./scripts/test