Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue causing status bar to block app controls #1014

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

SteveMicroNova
Copy link
Contributor

@SteveMicroNova SteveMicroNova commented Jan 7, 2025

What does this change intend to accomplish?

I found that our current StatusBar components would completely block all app controls on mobile, bump the bottom of the StatusBar up above the controls so you can now leave the problem screen

Before:
image

After:
image

Checklist

  • Have you tested your changes and ensured they work?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

web/src/App.scss Outdated Show resolved Hide resolved
@linknum23 linknum23 self-requested a review January 8, 2025 15:01
Copy link
Contributor

@linknum23 linknum23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a more robust solution. The only remaining question I have is: are there any places in the code that you want to document why the snack bar isn't at the bottom? Or any other breadcrumbs that you want to leave your future self. ( I realize that these changes are pretty minimal, just something to think about)

Implement navbar-height scss var
@SteveMicroNova SteveMicroNova merged commit d7bf478 into main Jan 8, 2025
3 checks passed
@SteveMicroNova SteveMicroNova deleted the StatusBarFix branch January 8, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants