Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Airplay icon #1009

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Update Airplay icon #1009

merged 1 commit into from
Jan 6, 2025

Conversation

SteveMicroNova
Copy link
Contributor

@SteveMicroNova SteveMicroNova commented Dec 18, 2024

What does this change intend to accomplish?

We noted that our airplay logo was out of date
It is now up to date using an official airplay logo

Sources:
Apple
Where I got the icon

Before:
image

After:
image

Checklist

  • Have you tested your changes and ensured they work?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • If applicable, have you updated the CHANGELOG?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

@gorski123
Copy link
Contributor

I think I prefer the circular lines with the triangle, or at the very least the box in blue?
airplay-custom-color-icon-set@2x

@@ -2,7 +2,7 @@ import spotify from "@/../static/imgs/spotify.png";
import dlna from "@/../static/imgs/dlna.png";
import bluetooth from "@/../static/imgs/bluetooth.png";
import fmradio from "@/../static/imgs/fmradio.png";
import shairport from "@/../static/imgs/shairport.png";
import shairport from "@/../static/imgs/shairport.svg";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is svg instead of png?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the icons in both large and small formats, svgs are better at not having jagged edges when you use CSS to scale them like that

However, I also grabbed a PNG because without one I'd have to change every other stream icon to SVG as well, and that's a larger lift than this issue deserved at this moment

I've decided to skip having two different image files and just keep it to PNGs

@linknum23
Copy link
Contributor

What is the difference in intent between the 2 icons? I assume one makes more sense for amplipi than the other.

@SteveMicroNova
Copy link
Contributor Author

What is the difference in intent between the 2 icons? I assume one makes more sense for amplipi than the other.

The triangle with three rings is for audio, the triangle in a rectangle is for audio and video. Not everywhere uses it as that, for example Pandora does not use any video but still uses that icon; I also used that icon because it was what was available in my trusted icon libraries for airplay
I've now replaced it with the Airplay Audio icon that I recolored blue by Jason's request above

@SteveMicroNova
Copy link
Contributor Author

To my understanding, Lincoln is taking on the task of finding a better icon that has better line thickness and a proper color
This PR is likely blocked by that

@klay2000
Copy link
Contributor

klay2000 commented Jan 6, 2025

I'm going to spend a few minutes looking into this.

Copy link
Contributor

@klay2000 klay2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the Apple human interface guidelines for Airplay these are the two icons. In quickly skimming through them I didn't see anything specifying that we should use either the radiating circles or rounded rectangle for audio however the consensus seems to be the radiating circles icon is for audio, so I believe it is most correct for us to use that.

As for the line weight, these are the icons apple provides, I doubt we're going to find anything with a finer line and if we do this is still in my opinion the best icon to use.

The color is a bit more complicated, Apple's guidelines basically say to use whatever you use for other services. We use the full color logo for Pandora but for everything else we use logos with at most 2 colors. I think we should use the blue as shown in the screenshots above but Apple seems to not specify what color to use, just that it's colored. Perhaps in the future we should make our iconography a little more concise by finding a 2 color version of the pandora logo and keeping the icons we have control over within a consistent color palate since at the moment some icons have very similar colors and I think this looks bad.

I definitely went a little crazy on this but overall I think we should just stick with the radiating circles icon in blue.

@SteveMicroNova SteveMicroNova merged commit acf8f7d into main Jan 6, 2025
3 checks passed
@SteveMicroNova SteveMicroNova deleted the CorrectAirplayLogo branch January 6, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants