-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Airplay icon #1009
Update Airplay icon #1009
Conversation
web/src/utils/getIcon.jsx
Outdated
@@ -2,7 +2,7 @@ import spotify from "@/../static/imgs/spotify.png"; | |||
import dlna from "@/../static/imgs/dlna.png"; | |||
import bluetooth from "@/../static/imgs/bluetooth.png"; | |||
import fmradio from "@/../static/imgs/fmradio.png"; | |||
import shairport from "@/../static/imgs/shairport.png"; | |||
import shairport from "@/../static/imgs/shairport.svg"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is svg instead of png?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the icons in both large and small formats, svgs are better at not having jagged edges when you use CSS to scale them like that
However, I also grabbed a PNG because without one I'd have to change every other stream icon to SVG as well, and that's a larger lift than this issue deserved at this moment
I've decided to skip having two different image files and just keep it to PNGs
What is the difference in intent between the 2 icons? I assume one makes more sense for amplipi than the other. |
The triangle with three rings is for audio, the triangle in a rectangle is for audio and video. Not everywhere uses it as that, for example Pandora does not use any video but still uses that icon; I also used that icon because it was what was available in my trusted icon libraries for airplay |
3fd5bef
to
6d7ad6b
Compare
To my understanding, Lincoln is taking on the task of finding a better icon that has better line thickness and a proper color |
I'm going to spend a few minutes looking into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Apple human interface guidelines for Airplay these are the two icons. In quickly skimming through them I didn't see anything specifying that we should use either the radiating circles or rounded rectangle for audio however the consensus seems to be the radiating circles icon is for audio, so I believe it is most correct for us to use that.
As for the line weight, these are the icons apple provides, I doubt we're going to find anything with a finer line and if we do this is still in my opinion the best icon to use.
The color is a bit more complicated, Apple's guidelines basically say to use whatever you use for other services. We use the full color logo for Pandora but for everything else we use logos with at most 2 colors. I think we should use the blue as shown in the screenshots above but Apple seems to not specify what color to use, just that it's colored. Perhaps in the future we should make our iconography a little more concise by finding a 2 color version of the pandora logo and keeping the icons we have control over within a consistent color palate since at the moment some icons have very similar colors and I think this looks bad.
I definitely went a little crazy on this but overall I think we should just stick with the radiating circles icon in blue.
What does this change intend to accomplish?
We noted that our airplay logo was out of date
It is now up to date using an official airplay logo
Sources:
Apple
Where I got the icon
Before:
After:
Checklist
./scripts/test