Persist Logs during updates #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMicroNova
commented
Dec 2, 2024
| @@ -44,7 +44,7 @@ <h1><span class="text-white">Ampli</span><span class="text-danger">Pi</span></h1 | |||
| <a class="nav-link" id="manual-update-tab" data-toggle="tab" href="#manual-update" role="tab" aria-controls="manual-update" aria-selected="false">Custom Update</a> | |||
| </li> | |||
| <li class="nav-item"> | |||
| <a class="nav-link" id="admin-settings-tab" data-toggle="tab" href="#admin-settings" role="tab" aria-controls="admin-settings" aria-selected="false">Admin Settings</a> | |||
| <a class="nav-link" id="admin-settings-tab" data-toggle="tab" href="#admin-settings" role="tab" aria-controls="admin-settings" aria-selected="false" onClick="getPersist();">Admin Settings</a> | |||
There was a problem hiding this comment.
Now that the state of that tab can be changed by updating, change the update method from window.onload to tab.onclick
SteveMicroNova
force-pushed
the
PersistLogsDuringUpdate
branch
5 times, most recently
from
a4eeba7 to
03f8e32
Compare
SteveMicroNova
force-pushed
the
PersistLogsDuringUpdate
branch
2 times, most recently
from
4ae34f0 to
b293dc8
Compare
linknum23
reviewed
Dec 9, 2024
…es, then set to true if it is false with sane minimum auto-off delay
SteveMicroNova
force-pushed
the
PersistLogsDuringUpdate
branch
from
0c21853 to
8a5422f
Compare
linknum23
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change intend to accomplish?
Adds a function prior to firing the update script that checks if persist_logs is set to true, and if not sets it to true for three days
Checklist
./scripts/test