Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup script directory removal failures #1003

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix cleanup script directory removal failures #1003

merged 1 commit into from
Dec 9, 2024

Conversation

linknum23
Copy link
Contributor

@linknum23 linknum23 commented Dec 2, 2024 •
edited
Loading

What does this change intend to accomplish?

Make the cleanup script work on the production testers again

Checklist

  • Have you tested your changes and ensured they work?

@linknum23 linknum23 marked this pull request as ready for review December 2, 2024 19:34
@linknum23 linknum23 requested a review from rtertiaer December 2, 2024 19:35
@linknum23
Copy link
Contributor Author

This has been tested on the production (aptestanalog) testers

@linknum23 linknum23 mentioned this pull request Dec 9, 2024
Closed
7 tasks
@linknum23
Copy link
Contributor Author

@SteveMicroNova I'm adding you to this. Please check out the changes and see if they make sense. They have been tested already.

SteveMicroNova
SteveMicroNova approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@SteveMicroNova SteveMicroNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only remove files from the folder, no folders nor files in said folders. Makes sense to me 👍

@linknum23 linknum23 merged commit 3e333e0 into main Dec 9, 2024
3 checks passed
@linknum23 linknum23 deleted the cleanup-config-dirs branch December 9, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMicroNova SteveMicroNova SteveMicroNova approved these changes

@rtertiaer rtertiaer Awaiting requested review from rtertiaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linknum23 @SteveMicroNova