Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UDP transport #134

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Add UDP transport #134

merged 7 commits into from
Dec 22, 2023

Conversation

Hao-Lion-ZJU
Copy link
Contributor

@Hao-Lion-ZJU
Add UDP transport
df8fa2c 
Signed-off-by: Lion Hao <[email protected]>
pablogs9
pablogs9 reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, thanks for your contribution!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
extra_sources/microros_transports/udp_transport.c Outdated Show resolved Hide resolved
extra_sources/microros_transports/udp_transport.c Outdated Show resolved Hide resolved
@Hao-Lion-ZJU
Copy link
Contributor Author

Some minor comments, thanks for your contribution!

@pablogs9 hello, I've fixed some of the possible errors in my code last week. Is there anything else that is inappropriate?

@Hao-Lion-ZJU
Copy link
Contributor Author

@pablogs9 Thank you for your correction. It has now been completely revised.

pablogs9
pablogs9 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last comment and we are good to go.

extra_sources/microros_transports/udp_transport.c Outdated Show resolved Hide resolved
extra_sources/microros_transports/udp_transport.c Outdated Show resolved Hide resolved
extra_sources/microros_transports/udp_transport.c Outdated Show resolved Hide resolved
extra_sources/microros_transports/udp_transport.c Outdated Show resolved Hide resolved
extra_sources/microros_transports/udp_transport.c Outdated Show resolved Hide resolved
extra_sources/microros_transports/udp_transport.c Outdated Show resolved Hide resolved
@Hao-Lion-ZJU
Copy link
Contributor Author

Some last comment and we are good to go.

Done. I should have been a little more careful before I commit the code, thank you for your patience. @pablogs9

@pablogs9
Minor fixes on readme
9131b4f 
Signed-off-by: Pablo Garrido <[email protected]>
@pablogs9
Copy link
Member

@mergify backport rolling humble

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 22, 2023 •
edited
Loading

backport rolling humble

✅ Backports have been created

@pablogs9 pablogs9 merged commit 0dbe8b6 into micro-ROS:iron Dec 22, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Dec 22, 2023
@Hao-Lion-ZJU @mergify
Add UDP transport (#134)
ffe3828 
* Add UDP transport

Signed-off-by: Lion Hao <[email protected]>

* Apply suggestions from code review

Co-authored-by: Pablo Garrido <[email protected]>

* Update README and modify recv flag

* Update udp_transport.c

* Apply suggestions from code review

Co-authored-by: Pablo Garrido <[email protected]>

* Update udp_transport.c

* Minor fixes on readme

Signed-off-by: Pablo Garrido <[email protected]>

---------

Signed-off-by: Lion Hao <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit 0dbe8b6)
@mergify mergify bot mentioned this pull request Dec 22, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 22, 2023
@Hao-Lion-ZJU @mergify
Add UDP transport (#134)
584c1f4 
* Add UDP transport

Signed-off-by: Lion Hao <[email protected]>

* Apply suggestions from code review

Co-authored-by: Pablo Garrido <[email protected]>

* Update README and modify recv flag

* Update udp_transport.c

* Apply suggestions from code review

Co-authored-by: Pablo Garrido <[email protected]>

* Update udp_transport.c

* Minor fixes on readme

Signed-off-by: Pablo Garrido <[email protected]>

---------

Signed-off-by: Lion Hao <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit 0dbe8b6)
@mergify mergify bot mentioned this pull request Dec 22, 2023
Merged
pablogs9 pushed a commit that referenced this pull request Dec 22, 2023
@mergify @Hao-Lion-ZJU
Add UDP transport (#134) (#135)
513d43c 
* Add UDP transport

Signed-off-by: Lion Hao <[email protected]>

* Apply suggestions from code review

Co-authored-by: Pablo Garrido <[email protected]>

* Update README and modify recv flag

* Update udp_transport.c

* Apply suggestions from code review

Co-authored-by: Pablo Garrido <[email protected]>

* Update udp_transport.c

* Minor fixes on readme

Signed-off-by: Pablo Garrido <[email protected]>

---------

Signed-off-by: Lion Hao <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit 0dbe8b6)

Co-authored-by: Lion Hao <[email protected]>
pablogs9 pushed a commit that referenced this pull request Dec 22, 2023
@mergify @Hao-Lion-ZJU
Add UDP transport (#134) (#136)
78cd506 
* Add UDP transport

Signed-off-by: Lion Hao <[email protected]>

* Apply suggestions from code review

Co-authored-by: Pablo Garrido <[email protected]>

* Update README and modify recv flag

* Update udp_transport.c

* Apply suggestions from code review

Co-authored-by: Pablo Garrido <[email protected]>

* Update udp_transport.c

* Minor fixes on readme

Signed-off-by: Pablo Garrido <[email protected]>

---------

Signed-off-by: Lion Hao <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit 0dbe8b6)

Co-authored-by: Lion Hao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 Awaiting requested review from pablogs9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hao-Lion-ZJU @pablogs9