Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stop functionality #89

Open
wants to merge 22 commits into
base: rolling
Choose a base branch
from
Open

Add stop functionality #89

wants to merge 22 commits into from

Conversation

Acuadros95
Copy link
Contributor

@Acuadros95 Acuadros95 commented Jul 21, 2021 •
edited
Loading

  • Todo: modify cmake to build as library

mergify bot and others added 6 commits July 2, 2021 09:48
@mergify @pablogs9
Fix graph manager node namespaces (#72) (#74)
a313a08 
(cherry picked from commit a623308)

Co-authored-by: Pablo Garrido <[email protected]>
@mergify @pablogs9
Fix graph manager node namespaces (#75) (#77)
ee955ed 
* Fix graph manager node namespaces

* Update

(cherry picked from commit f6a2aa3)

Co-authored-by: Pablo Garrido <[email protected]>
@mergify @pablogs9
Fix agent launch (#78) (#80)
a8caaa1 
Co-authored-by: Your Name <[email protected]>
(cherry picked from commit 69f17c2)

Co-authored-by: Pablo Garrido <[email protected]>
@mergify @pablogs9
Graph manager: Fix participant mask for listener callbacks (#81) (#82)
e43cde1 
(cherry picked from commit 95fecd7)

Co-authored-by: Pablo Garrido <[email protected]>
@mergify @pablogs9
Fix graph manager datawriters behaviour (#84) (#85)
256424b 
* Fix graph manager datawriters

Fixes

Fix

Fix destruction

* Revert "Fix graph manager datawriters"

This reverts commit 2847a2e.

* Initial

(cherry picked from commit 646ca52)

Co-authored-by: Pablo Garrido <[email protected]>
@Acuadros95
Add stop functionality
ff3b6f3
@Acuadros95 Acuadros95 requested a review from pablogs9 July 21, 2021 11:49
@Acuadros95
Copy link
Contributor Author

@mergify backport galactic foxy

@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2021 •
edited
Loading

backport galactic foxy

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@pablogs9
Copy link
Member

This PR should target main branch and be backported to galactic and foxy

@Acuadros95 Acuadros95 changed the base branch from galactic to main July 27, 2021 13:33
pablogs9
pablogs9 reviewed Jul 28, 2021
View reviewed changes
micro_ros_agent/include/agent/graph_manager/graph_manager.hpp
if (microros_graph_publisher_.joinable())
{
exit = true;
cv_.notify_one();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Acuadros95 @pablogs9