-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] V5 #51
Open
kesla
wants to merge
7
commits into
master
Choose a base branch
from
v5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[wip] V5 #51
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1ebf323
miclint miclint
kesla 9b074a2
enforce throwing/rejecting only Error:s
kesla 3c255ba
more flow
kesla 3fba5a1
Merge pull request #50 from micnews/lint-miclint
kesla d9e78c8
Add changelog
kesla a3de468
Add engines field in package.json
kesla 4b24c7c
update deps, skip defaultProps in flow
kesla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
#!/usr/bin/env node | ||
/* eslint-disable import/no-commonjs */ | ||
const options = require('./options'); | ||
|
||
var options = require('./options'); | ||
var flow = process.argv.indexOf('--flow') !== -1; | ||
const flow = process.argv.indexOf('--flow') !== -1; | ||
|
||
require('standard-engine').cli(flow ? options.flow : options); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# v5.0 | ||
* **change** enforce using Errors in throws and when rejecting Promises | ||
* **change** Changes to the flow mode (`miclint --flow`) | ||
* Functions must have return type annotation | ||
* Files must have a file annotation and it must always use the line version (`// @flow`) | ||
* Functions must have parameter type annotation | ||
* React: Don't require defaultProps | ||
* **internal** Lint miclint! | ||
|
||
# v4.1.2 | ||
|
||
* **bugfix** Allow multiple imports in flow mode (`miclint --flow`) to import flow types (`import type { foo } from 'bar';`) | ||
|
||
# v4.1 | ||
|
||
* **feature** `miclint --flow` will now lint with specific lint rules | ||
|
||
# 4.0 | ||
* **change** enforce ES6 import / exports | ||
* **change** enforce display names on react components | ||
* **change** enforce presence of keys on react iterator children | ||
* **change** enforce presence of dangling commas |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
var Linter = require('standard-engine').linter; | ||
var options = require('./options'); | ||
/* eslint-disable import/no-commonjs */ | ||
const Linter = require('standard-engine').linter; | ||
const options = require('./options'); | ||
|
||
module.exports = new Linter(options); | ||
module.exports = new Linter(options); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why bin.js twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we check bin w bin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first we run bin, then we check it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can I make that more obvious somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kesla sorry for delayed response, can it not support globs?
node bin.js *.js
?